[release/10.0][HTTP/SSL] Fix stress test#125128
Open
ManickaP wants to merge 1 commit intodotnet:release/10.0from
Open
[release/10.0][HTTP/SSL] Fix stress test#125128ManickaP wants to merge 1 commit intodotnet:release/10.0from
ManickaP wants to merge 1 commit intodotnet:release/10.0from
Conversation
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the HTTP and SSL stress-test MSBuild props to ensure a valid runtime framework version is chosen when building in Docker contexts where eng/Versions.props isn’t present, preventing failures due to an unset ProductVersion.
Changes:
- Add a fallback
ProductVersionvalue when it’s unset. - Default
ProductVersionto$(NetCoreAppCurrentVersion).0to allow roll-forward to the available testhost runtime.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/libraries/System.Net.Security/tests/StressTests/SslStress/Directory.Build.props | Adds a Docker-safe fallback for ProductVersion to keep local targeting/runtime pack resolution working. |
| src/libraries/System.Net.Http/tests/StressTests/HttpStress/Directory.Build.props | Mirrors the same ProductVersion fallback to keep HttpStress Docker builds aligned with the testhost runtime. |
rzikm
reviewed
Mar 3, 2026
src/libraries/System.Net.Http/tests/StressTests/HttpStress/Directory.Build.props
Show resolved
Hide resolved
Member
Author
|
Both pipelines are passing now on 10.0 branch:
Test only change --> tell mode. |
src/libraries/System.Net.Security/tests/StressTests/SslStress/Directory.Build.props
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Http/tests/StressTests/HttpStress/Directory.Build.props
Outdated
Show resolved
Hide resolved
3 tasks
Member
Author
|
/azp run runtime-libraries stress-http |
|
Azure Pipelines successfully started running 1 pipeline(s). |
src/libraries/System.Net.Http/tests/StressTests/HttpStress/Directory.Build.props
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Security/tests/StressTests/SslStress/Directory.Build.props
Outdated
Show resolved
Hide resolved
…sion mismatch The stress test Docker pipeline installs the latest daily SDK from the 10.0 channel, which has advanced to targeting framework 10.0.6. However, the release/10.0 branch builds runtime version 10.0.5. In Docker, the stress test projects cannot import eng/Versions.props (repo root is unavailable), so ProductVersion is empty and the SDK defaults to its own framework version (10.0.6), causing a runtime mismatch at launch. Fix by extracting PatchVersion in the build scripts and passing the full ProductVersion (e.g., 10.0.5) as a Docker build arg through to dotnet build. This ensures the runtimeconfig.json always requests the framework version matching the locally-built runtime, regardless of SDK version drift. Affects HttpStress and SslStress on both Linux and Windows. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
/azp run runtime-libraries stress-http |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run runtime-libraries stress-http |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customer Impact
Fixes .NET version for testhost being older than the latest greatest daily build.
Regression
Testing
CI stress tests pipeline.
Risk
Low, test only change, no product code change.