Remove stale information in ArrayPool.Shared remarks#125109
Merged
jkotas merged 1 commit intodotnet:mainfrom Mar 3, 2026
Merged
Remove stale information in ArrayPool.Shared remarks#125109jkotas merged 1 commit intodotnet:mainfrom
jkotas merged 1 commit intodotnet:mainfrom
Conversation
There no longer is any special handling of bytes/chars when using the shared array pool
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-buffers |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes outdated XML documentation on ArrayPool<T>.Shared that referenced special pooling behavior for byte[]/char[], aligning the remarks with the current SharedArrayPool<T> implementation.
Changes:
- Deleted stale remarks claiming
byte[]/char[]use a special optimized pool implementation.
stephentoub
approved these changes
Mar 3, 2026
Member
stephentoub
left a comment
There was a problem hiding this comment.
Thanks. Yes, the special-casing was removed years ago in lolleko@55117cd#diff-ea6685d3a394b3859a91b3765060078fe0b7a9dc9989f30cd8893bd55cc853f3.
jkotas
approved these changes
Mar 3, 2026
Member
|
/ba-g OSX timeout |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was copying the SharedArrayPool implementation to create a slightly modified version of it.
Stumbled across this part of the doc comment, looking for this special handling to replicate it too.
But I couldn't find any special handling for byte or char arrays.
Pretty sure his was removed at some point and the comment was not updated to reflect the changes.
I searched through the history and this seems to be the commit that removed the special handling:
55117cd#diff-ea6685d3a394b3859a91b3765060078fe0b7a9dc9989f30cd8893bd55cc853f3