Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes getdomainname() availability on SunOS so System.Net.NetworkInformation.Functional.Tests can run without aborting, by correctly detecting and linking the required SunOS libraries and adding a missing declaration.
Changes:
- Update CMake configuration to detect
getdomainnameon SunOS viacheck_function_existswhile linking againstsocket/nsl. - Add an explicit
getdomainnameprototype for SunOS builds where no header declares it. - Link
System.Nativeagainstlibnslon SunOS.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/native/libs/configure.cmake | SunOS-specific getdomainname detection with required link libraries and restoration of CMAKE_REQUIRED_LIBRARIES. |
| src/native/libs/System.Native/pal_networking.c | Adds SunOS-only getdomainname forward declaration when the function is available. |
| src/native/libs/System.Native/extra_libs.cmake | Ensures System.Native links socket and nsl on SunOS. |
This was referenced Mar 2, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests (System.Net.NetworkInformation.Functional.Tests) being used to validate the work in #124728 need getdomainname() to work or else the test will abort and dump core. This fixes that for SunOS.