Remove some of unsafe code in Base64 decoder#124761
Closed
EgorBo wants to merge 1 commit intodotnet:mainfrom
Closed
Remove some of unsafe code in Base64 decoder#124761EgorBo wants to merge 1 commit intodotnet:mainfrom
EgorBo wants to merge 1 commit intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-buffers |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces unsafe code usage in the Base64 / Base64Url decoding helpers by switching the scalar decoding helpers from raw pointers to ReadOnlySpan<T> and index-based processing, while keeping unsafe code for the SIMD hot loops.
Changes:
- Updated
IBase64Decoder<T>to decode scalar blocks viaReadOnlySpan<T>instead ofT*pointers. - Adjusted Base64Url decoder wrappers to match the new span-based decoder API.
- Refactored core decode helpers to use indices + spans (and updated the “write 3 bytes” helper accordingly), limiting pinning to SIMD paths.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/libraries/System.Private.CoreLib/src/System/Buffers/Text/Base64Url/Base64UrlDecoder.cs | Updates Base64Url decoder wrapper methods to use span-based scalar decode APIs (removes unsafe pointer params for these helpers). |
| src/libraries/System.Private.CoreLib/src/System/Buffers/Text/Base64Helper/Base64Helper.cs | Changes IBase64Decoder<T> scalar decode method signatures from pointers to ReadOnlySpan<T>. |
| src/libraries/System.Private.CoreLib/src/System/Buffers/Text/Base64Helper/Base64DecoderHelper.cs | Refactors scalar decoding and in-place decoding loops to use spans/indices instead of pointer arithmetic; keeps pinning only for SIMD decode paths. |
...libraries/System.Private.CoreLib/src/System/Buffers/Text/Base64Helper/Base64DecoderHelper.cs
Outdated
Show resolved
Hide resolved
...libraries/System.Private.CoreLib/src/System/Buffers/Text/Base64Helper/Base64DecoderHelper.cs
Show resolved
Hide resolved
Member
Author
1caff26 to
b30129c
Compare
Member
Author
Member
Author
|
@EgorBot -arm -amd --filter "Perf_Base64" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still keeping some unsafe for hot SIMD loop (will try to remove that too) or if it has a lot of unsafe callers