Add blittable color types Argb<T> and Rgba<T> to System.Numerics.Vectors#124663
Merged
ViveliDuCh merged 11 commits intodotnet:mainfrom Mar 2, 2026
Merged
Add blittable color types Argb<T> and Rgba<T> to System.Numerics.Vectors#124663ViveliDuCh merged 11 commits intodotnet:mainfrom
ViveliDuCh merged 11 commits intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces new blittable color primitives (Argb<T> and Rgba<T>) under System.Numerics.Colors, implemented directly in the System.Numerics.Vectors partial-facade assembly, and wires them into System.Drawing.Color for efficient interop-friendly conversions.
Changes:
- Add
System.Numerics.Colors.Argb<T>/Rgba<T>implementations plus uint endianness helpers. - Add
System.Drawing.Colorinterop APIs (FromArgb(Argb<byte>),ToArgbValue(), and cast operators) and expand test coverage. - Update
System.Numerics.Vectorsref surface and add new unit tests for the new types.
Reviewed changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 29 comments.
Show a summary per file
| File | Description |
|---|---|
| src/libraries/System.Numerics.Vectors/src/System.Numerics.Vectors.csproj | Enables partial contract move + compiles new Colors types into the facade assembly. |
| src/libraries/System.Numerics.Vectors/src/System/ThrowHelper.cs | Adds argument-validation helper for span-based color APIs. |
| src/libraries/System.Numerics.Vectors/src/System/Numerics/Colors/Argb.cs | Adds uint conversion helpers for Argb<byte>. |
| src/libraries/System.Numerics.Vectors/src/System/Numerics/Colors/Argb.T.cs | Adds generic Argb<T> blittable struct implementation. |
| src/libraries/System.Numerics.Vectors/src/System/Numerics/Colors/Rgba.cs | Adds uint conversion helpers for Rgba<byte>. |
| src/libraries/System.Numerics.Vectors/src/System/Numerics/Colors/Rgba.T.cs | Adds generic Rgba<T> blittable struct implementation. |
| src/libraries/System.Numerics.Vectors/src/Resources/Strings.resx | Introduces resource string for span-length validation errors. |
| src/libraries/System.Numerics.Vectors/ref/System.Numerics.Vectors.csproj | Includes the new System.Numerics.Colors ref file in the ref assembly build. |
| src/libraries/System.Numerics.Vectors/ref/System.Numerics.Colors.cs | Declares the public ref surface for System.Numerics.Colors types. |
| src/libraries/System.Numerics.Vectors/tests/System.Numerics.Vectors.Tests.csproj | Adds the new Colors test files to the test project build. |
| src/libraries/System.Numerics.Vectors/tests/TestHelpers.cs | Adds shared test data + numeric helpers for the color tests. |
| src/libraries/System.Numerics.Vectors/tests/Argb.Tests.cs | Adds unit tests for Argb static endianness helpers. |
| src/libraries/System.Numerics.Vectors/tests/Argb.T.Tests.cs | Adds unit tests for Argb<T> struct behaviors. |
| src/libraries/System.Numerics.Vectors/tests/Rgba.Tests.cs | Adds unit tests for Rgba static endianness helpers. |
| src/libraries/System.Numerics.Vectors/tests/Rgba.T.Tests.cs | Adds unit tests for Rgba<T> struct behaviors. |
| src/libraries/System.Drawing.Primitives/src/System/Drawing/Color.cs | Adds conversion APIs between Color and Argb<byte>. |
| src/libraries/System.Drawing.Primitives/ref/System.Drawing.Primitives.cs | Updates the ref surface for new Color APIs. |
| src/libraries/System.Drawing.Primitives/tests/ColorTests.cs | Adds tests for the new Color <-> Argb<byte> APIs. |
| src/libraries/System.Drawing.Primitives/tests/ColorTranslatorTests.cs | Normalizes test namespace naming. |
| src/libraries/System.Drawing.Primitives/tests/PointTests.cs | Normalizes test namespace naming. |
| src/libraries/System.Drawing.Primitives/tests/PointFTests.cs | Normalizes test namespace naming. |
| src/libraries/System.Drawing.Primitives/tests/RectangleTests.cs | Normalizes test namespace naming. |
| src/libraries/System.Drawing.Primitives/tests/RectangleFTests.cs | Normalizes test namespace naming. |
| src/libraries/System.Drawing.Primitives/tests/SizeTests.cs | Normalizes test namespace naming. |
| src/libraries/System.Drawing.Primitives/tests/SizeFTests.cs | Normalizes test namespace naming. |
| src/libraries/System.ComponentModel.TypeConverter/src/System.ComponentModel.TypeConverter.csproj | Adds a project reference to System.Numerics.Vectors. |
src/libraries/System.Numerics.Vectors/src/System/Numerics/Colors/Argb.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Numerics.Vectors/ref/System.Numerics.Colors.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Numerics/Colors/Argb.T.cs
Show resolved
Hide resolved
src/libraries/System.Numerics.Vectors/src/System/Numerics/Colors/Argb.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Numerics.Vectors/src/System/Numerics/Colors/Argb.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Numerics.Vectors/src/System/Numerics/Colors/Rgba.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Numerics/Colors/Rgba.T.cs
Show resolved
Hide resolved
src/libraries/System.Numerics.Vectors/ref/System.Numerics.Colors.cs
Outdated
Show resolved
Hide resolved
ericstj
reviewed
Feb 20, 2026
src/libraries/System.Numerics.Vectors/ref/System.Numerics.Vectors.csproj
Outdated
Show resolved
Hide resolved
ericstj
reviewed
Feb 20, 2026
src/libraries/System.Drawing.Primitives/ref/System.Drawing.Primitives.cs
Show resolved
Hide resolved
This was referenced Feb 20, 2026
src/libraries/System.Drawing.Primitives/src/System/Drawing/Color.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Drawing.Primitives/src/System/Drawing/Color.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Numerics.Vectors/src/System/Numerics/Colors/Argb.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Numerics.Vectors/src/System/Numerics/Colors/Argb.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Numerics.Vectors/src/System/Numerics/Colors/Argb.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Numerics.Vectors/src/System/Numerics/Colors/Argb.cs
Outdated
Show resolved
Hide resolved
d69511e to
936ddab
Compare
src/libraries/System.Numerics.Vectors/src/System/Numerics/Colors/Rgba.T.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Numerics.Vectors/src/System/Numerics/Colors/Argb.T.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Numerics.Vectors/src/System/Numerics/Colors/Argb.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Numerics.Vectors/src/System/Numerics/Colors/Argb.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Numerics.Vectors/src/System/Numerics/Colors/Argb.T.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Numerics.Vectors/src/System/Numerics/Colors/Rgba.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Numerics.Vectors/src/System/Numerics/Colors/Rgba.cs
Outdated
Show resolved
Hide resolved
ericstj
reviewed
Feb 23, 2026
src/libraries/System.Numerics.Vectors/ref/System.Numerics.Vectors.cs
Outdated
Show resolved
Hide resolved
ericstj
reviewed
Feb 23, 2026
src/libraries/System.Numerics.Vectors/ref/System.Numerics.Vectors.cs
Outdated
Show resolved
Hide resolved
ericstj
approved these changes
Feb 23, 2026
jkotas
requested changes
Feb 26, 2026
Member
jkotas
left a comment
There was a problem hiding this comment.
I do not think adding this to System.Numetics.Vectors is a good plan
Member
|
My preference would be to add these types to System.Drawing.Common. If it is not acceptable, we should add them to System.Private.Corelib. It is slightly better perf-wise than adding them to System.Numerics.Vectors. We have number of other graphics related types in CoreLib for historic reasons (and we cannot fix that since they got a cycle with intrinsics now), adding a few more would be consistent with that at least. |
Member
|
Reposting since the review comment might be hidden but the agreement from the discussion in #124663 (comment) was to move the implementation to Corelib. |
src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems
Show resolved
Hide resolved
Member
Author
|
@jkotas, @tannergooding, @ericstj, @akoeplinger, @JeremyKuhne Thanks everyone for the thorough discussion/debate on where these types should live. I really appreciate the different perspectives. Per the consensus reached, I've moved the Color type implementations into System.Private.CoreLib alongside the other System.Numerics types, with System.Numerics.Vectors remaining a pure facade. |
tannergooding
approved these changes
Feb 28, 2026
ericstj
approved these changes
Feb 28, 2026
jkotas
reviewed
Feb 28, 2026
src/libraries/System.Numerics.Vectors/ref/System.Numerics.Vectors.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Feb 28, 2026
src/libraries/System.Private.CoreLib/src/System/Numerics/Colors/Argb.T.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Feb 28, 2026
jkotas
reviewed
Feb 28, 2026
src/libraries/System.Private.CoreLib/src/Resources/Strings.resx
Outdated
Show resolved
Hide resolved
…per for color types
Member
Author
|
/ba-g Opened issue #125037 for the unknown test error |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #48615
This PR builds on @AlexRadch's original implementation in #106575 and addresses the review feedback to avoid introducing a new assembly. The
ArgbandRgbacolor types are placed inSystem.Private.CoreLibalongside the otherSystem.Numericstypes (Vector2, Matrix4x4, Quaternion, etc.), withSystem.Numerics.Vectorsremaining a pure facade assembly that forwards all types from CoreLib.Original work by @AlexRadch:
Argb<T>,Rgba<T>struct implementations with static helper methodsSystem.Drawing.Primitivesintegration (Color.FromArgb/ToArgbValue)System.ComponentModel.TypeConvertersupportAddressing review feedback:
System.Private.CoreLib(src/System/Numerics/Colors/) following the same pattern as existing Numerics types.System.Numerics.Vectorsas a pure facade (noContractTypesPartiallyMoved, no compiled source)System.Numerics.Colorsproject (NetCoreAppLibrary.props, netstandard shim, Drawing.Primitives, TypeConverter, crossgen2_comparison.py)<ProjectReference>over bare<Reference>, remove redundant properties)