Enable runtime-async for System.IO.Compression and System.IO.Compression.Brotli by Copilot · Pull Request #124397 · dotnet/runtime

Copilot · 2026-02-13T18:44:01Z

Description

Enables the runtime-async compiler feature on the System.IO.Compression and System.IO.Compression.Brotli source libraries to allow performance testing of runtime-async with compression workloads.

Adds <Features>$(Features);runtime-async=on</Features> to both library csproj files
Guards enablement with conditions matching eng/testing/tests.targets: excluded for browser, wasi, and Mono targets where runtime-async is unsupported

All existing tests pass (1400 System.IO.Compression, 328 Brotli). Full clr+libs build succeeds with 0 warnings and 0 errors.

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…ion.Brotli Co-authored-by: agocke <515774+agocke@users.noreply.github.com>

agocke · 2026-02-13T19:33:42Z

/benchmark

pr-benchmarks · 2026-02-13T19:34:01Z

Crank Pull Request Bot

/benchmark <benchmark[,...]> <profile[,...]> <component,[...]> <arguments>

Benchmarks:

micro: .NET Performance micro benchmarks (set filter by adding --variable filter=...; by default filter=*LinqBenchmarks*)
plaintext: TechEmpower Plaintext Scenario - ASP.NET Platform implementation
json: TechEmpower JSON Scenario - ASP.NET Platform implementation
fortunes: TechEmpower Fortunes Scenario - ASP.NET Platform implementation
fortunes_ef: TechEmpower Fortunes Scenario with EF Core - ASP.NET Platform implementation

Profiles:

aspnet-citrine-ampere: Ampere/Linux 80 Cores

Components:

runtime
libs

Arguments: any additional arguments to pass through to crank, e.g. --variable name=value

pr-benchmarks · 2026-02-13T19:45:53Z

Crank Pull Request Bot

/benchmark <benchmark[,...]> <profile[,...]> <component,[...]> <arguments>

Benchmarks:

micro: .NET Performance micro benchmarks (set filter by adding --variable filter=...; by default filter=*LinqBenchmarks*)
plaintext: TechEmpower Plaintext Scenario - ASP.NET Platform implementation
json: TechEmpower JSON Scenario - ASP.NET Platform implementation
fortunes: TechEmpower Fortunes Scenario - ASP.NET Platform implementation
fortunes_ef: TechEmpower Fortunes Scenario with EF Core - ASP.NET Platform implementation
httpclient: HttpClient Benchmark (change HTTP version by adding e.g. --variable httpVersion=3.0; change response size by adding e.g. --variable responseSize=256; default: HTTP/1.1 GET 8K)

Profiles:

aspnet-perf-win: Intel/Windows 12 Cores
aspnet-citrine-win: Intel/Windows 28 Cores

Components:

runtime
libs

Arguments: any additional arguments to pass through to crank, e.g. --variable name=value

pr-benchmarks · 2026-02-13T19:46:03Z

Crank Pull Request Bot

/benchmark <benchmark[,...]> <profile[,...]> <component,[...]> <arguments>

Benchmarks:

micro: .NET Performance micro benchmarks (set filter by adding --variable filter=...; by default filter=*LinqBenchmarks*)
plaintext: TechEmpower Plaintext Scenario - ASP.NET Platform implementation
json: TechEmpower JSON Scenario - ASP.NET Platform implementation
fortunes: TechEmpower Fortunes Scenario - ASP.NET Platform implementation
fortunes_ef: TechEmpower Fortunes Scenario with EF Core - ASP.NET Platform implementation

Profiles:

aspnet-citrine-win-ampere: Ampere/Windows 80 Cores

Components:

runtime
libs

Arguments: any additional arguments to pass through to crank, e.g. --variable name=value

agocke · 2026-02-13T20:08:11Z

/benchmark micro

pr-benchmarks · 2026-02-13T20:11:03Z

Crank Pull Request Bot

/benchmark <benchmark[,...]> <profile[,...]> <component,[...]> <arguments>

Benchmarks:

micro: .NET Performance micro benchmarks (set filter by adding --variable filter=...; by default filter=*LinqBenchmarks*)
plaintext: TechEmpower Plaintext Scenario - ASP.NET Platform implementation
json: TechEmpower JSON Scenario - ASP.NET Platform implementation
fortunes: TechEmpower Fortunes Scenario - ASP.NET Platform implementation
fortunes_ef: TechEmpower Fortunes Scenario with EF Core - ASP.NET Platform implementation
httpclient: HttpClient Benchmark (change HTTP version by adding e.g. --variable httpVersion=3.0; change response size by adding e.g. --variable responseSize=256; default: HTTP/1.1 GET 8K)

Profiles:

aspnet-perf-win: Intel/Windows 12 Cores
aspnet-citrine-win: Intel/Windows 28 Cores

Components:

runtime
libs

Arguments: any additional arguments to pass through to crank, e.g. --variable name=value

pr-benchmarks · 2026-02-13T20:11:13Z

Crank Pull Request Bot

/benchmark <benchmark[,...]> <profile[,...]> <component,[...]> <arguments>

Benchmarks:

micro: .NET Performance micro benchmarks (set filter by adding --variable filter=...; by default filter=*LinqBenchmarks*)
plaintext: TechEmpower Plaintext Scenario - ASP.NET Platform implementation
json: TechEmpower JSON Scenario - ASP.NET Platform implementation
fortunes: TechEmpower Fortunes Scenario - ASP.NET Platform implementation
fortunes_ef: TechEmpower Fortunes Scenario with EF Core - ASP.NET Platform implementation

Profiles:

aspnet-citrine-win-ampere: Ampere/Windows 80 Cores

Components:

runtime
libs

Arguments: any additional arguments to pass through to crank, e.g. --variable name=value

pr-benchmarks · 2026-02-13T20:14:26Z

Crank Pull Request Bot

/benchmark <benchmark[,...]> <profile[,...]> <component,[...]> <arguments>

Benchmarks:

micro: .NET Performance micro benchmarks (set filter by adding --variable filter=...; by default filter=*LinqBenchmarks*)
plaintext: TechEmpower Plaintext Scenario - ASP.NET Platform implementation
json: TechEmpower JSON Scenario - ASP.NET Platform implementation
fortunes: TechEmpower Fortunes Scenario - ASP.NET Platform implementation
fortunes_ef: TechEmpower Fortunes Scenario with EF Core - ASP.NET Platform implementation
httpclient: HttpClient Benchmark (change HTTP version by adding e.g. --variable httpVersion=3.0; change response size by adding e.g. --variable responseSize=256; default: HTTP/1.1 GET 8K)

Profiles:

aspnet-citrine-lin: Intel/Linux 28 Cores
aspnet-perf-lin: Intel/Linux 12 Cores

Components:

runtime
libs

Arguments: any additional arguments to pass through to crank, e.g. --variable name=value

pr-benchmarks · 2026-02-13T20:14:33Z

Crank Pull Request Bot

/benchmark <benchmark[,...]> <profile[,...]> <component,[...]> <arguments>

Benchmarks:

micro: .NET Performance micro benchmarks (set filter by adding --variable filter=...; by default filter=*LinqBenchmarks*)
plaintext: TechEmpower Plaintext Scenario - ASP.NET Platform implementation
json: TechEmpower JSON Scenario - ASP.NET Platform implementation
fortunes: TechEmpower Fortunes Scenario - ASP.NET Platform implementation
fortunes_ef: TechEmpower Fortunes Scenario with EF Core - ASP.NET Platform implementation

Profiles:

aspnet-citrine-ampere: Ampere/Linux 80 Cores

Components:

runtime
libs

Arguments: any additional arguments to pass through to crank, e.g. --variable name=value

agocke · 2026-02-13T20:15:53Z

/benchmark micro libs

pr-benchmarks · 2026-02-13T20:33:27Z

Crank Pull Request Bot

/benchmark <benchmark[,...]> <profile[,...]> <component,[...]> <arguments>

Benchmarks:

micro: .NET Performance micro benchmarks (set filter by adding --variable filter=...; by default filter=*LinqBenchmarks*)
plaintext: TechEmpower Plaintext Scenario - ASP.NET Platform implementation
json: TechEmpower JSON Scenario - ASP.NET Platform implementation
fortunes: TechEmpower Fortunes Scenario - ASP.NET Platform implementation
fortunes_ef: TechEmpower Fortunes Scenario with EF Core - ASP.NET Platform implementation
httpclient: HttpClient Benchmark (change HTTP version by adding e.g. --variable httpVersion=3.0; change response size by adding e.g. --variable responseSize=256; default: HTTP/1.1 GET 8K)

Profiles:

aspnet-citrine-lin: Intel/Linux 28 Cores
aspnet-perf-lin: Intel/Linux 12 Cores

Components:

runtime
libs

Arguments: any additional arguments to pass through to crank, e.g. --variable name=value

pr-benchmarks · 2026-02-13T20:33:35Z

Crank Pull Request Bot

/benchmark <benchmark[,...]> <profile[,...]> <component,[...]> <arguments>

Benchmarks:

micro: .NET Performance micro benchmarks (set filter by adding --variable filter=...; by default filter=*LinqBenchmarks*)
plaintext: TechEmpower Plaintext Scenario - ASP.NET Platform implementation
json: TechEmpower JSON Scenario - ASP.NET Platform implementation
fortunes: TechEmpower Fortunes Scenario - ASP.NET Platform implementation
fortunes_ef: TechEmpower Fortunes Scenario with EF Core - ASP.NET Platform implementation

Profiles:

aspnet-citrine-ampere: Ampere/Linux 80 Cores

Components:

runtime
libs

Arguments: any additional arguments to pass through to crank, e.g. --variable name=value

pr-benchmarks · 2026-02-13T20:43:58Z

Crank Pull Request Bot

/benchmark <benchmark[,...]> <profile[,...]> <component,[...]> <arguments>

Benchmarks:

micro: .NET Performance micro benchmarks (set filter by adding --variable filter=...; by default filter=*LinqBenchmarks*)
plaintext: TechEmpower Plaintext Scenario - ASP.NET Platform implementation
json: TechEmpower JSON Scenario - ASP.NET Platform implementation
fortunes: TechEmpower Fortunes Scenario - ASP.NET Platform implementation
fortunes_ef: TechEmpower Fortunes Scenario with EF Core - ASP.NET Platform implementation
httpclient: HttpClient Benchmark (change HTTP version by adding e.g. --variable httpVersion=3.0; change response size by adding e.g. --variable responseSize=256; default: HTTP/1.1 GET 8K)

Profiles:

aspnet-perf-win: Intel/Windows 12 Cores
aspnet-citrine-win: Intel/Windows 28 Cores

Components:

runtime
libs

Arguments: any additional arguments to pass through to crank, e.g. --variable name=value

pr-benchmarks · 2026-02-13T20:44:07Z

Crank Pull Request Bot

/benchmark <benchmark[,...]> <profile[,...]> <component,[...]> <arguments>

Benchmarks:

micro: .NET Performance micro benchmarks (set filter by adding --variable filter=...; by default filter=*LinqBenchmarks*)
plaintext: TechEmpower Plaintext Scenario - ASP.NET Platform implementation
json: TechEmpower JSON Scenario - ASP.NET Platform implementation
fortunes: TechEmpower Fortunes Scenario - ASP.NET Platform implementation
fortunes_ef: TechEmpower Fortunes Scenario with EF Core - ASP.NET Platform implementation

Profiles:

aspnet-citrine-win-ampere: Ampere/Windows 80 Cores

Components:

runtime
libs

Arguments: any additional arguments to pass through to crank, e.g. --variable name=value

agocke · 2026-02-13T23:04:32Z

/benchmark micro aspnet-perf-lin libs

pr-benchmarks · 2026-02-13T23:13:59Z

Benchmark started for micro on aspnet-perf-lin with libs. Logs: link

pr-benchmarks · 2026-02-13T23:16:43Z

An error occurred, please check the logs

…ropagation for all three libraries Co-authored-by: agocke <515774+agocke@users.noreply.github.com>

Copilot · 2026-02-14T00:22:10Z

@copilot please also enable preview features for System.Net.WebSockets

Done in 06236ed. Also fixed all three libraries to use NoWarn CA2252 instead of EnablePreviewFeatures — the latter was generating [assembly: RequiresPreviewFeatures] which broke the System type-forwarding shim. All 570 WebSockets tests pass.

agocke · 2026-02-17T19:03:37Z

/benchmark micro aspnet-perf-lin libs

pr-benchmarks · 2026-02-17T19:19:34Z

Benchmark started for micro on aspnet-perf-lin with libs. Logs: link

pr-benchmarks · 2026-02-17T19:22:19Z

An error occurred, please check the logs

iremyux · 2026-02-19T14:19:48Z

Hey @agocke , we triaged this inside the team because it got labeled System.IO.Compression. But it seems like it's mislabeled, can you please change it to something more suitable?

agocke · 2026-02-19T17:34:59Z

@DrewScoggins am I doing something wrong with the benchmarking here? It seems like this should work, but I can’t see the results and these errors don’t make sense

agocke · 2026-02-19T17:35:45Z

@iremyux this is a draft pr, we can leave it untriaged

DrewScoggins · 2026-02-19T19:37:55Z

Took a look, and the issue is that an environment variable is not being set properly, and we try to restore for older TFMs. Taking a step back, this feature was written by Sebestian, and we don't use it or really maintain it. I am going to spend some time today to look at this feature and get it working again, as well as understand what and how it works.

dotnet-policy-service · 2026-02-20T08:41:14Z

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

…ime-async-compression

agocke · 2026-03-10T17:19:41Z

src/libraries/System.IO.Compression/src/System.IO.Compression.csproj

+  <PropertyGroup Condition="'$(TargetOS)' != 'browser'
+    and '$(TargetOS)' != 'wasi'
+    and '$(RuntimeFlavor)' != 'Mono'">
+    <NoWarn>$(NoWarn);CA2252</NoWarn>


@copilot Please remove the <NoWarn> additions (they should no longer be necessary) and undo the changes to WebSockets

Done in 766c789. Removed NoWarn CA2252 from both compression csproj files and fully reverted the WebSockets changes.

… changes Co-authored-by: agocke <515774+agocke@users.noreply.github.com>

Initial plan

610dfe0

Copilot AI assigned Copilot and agocke Feb 13, 2026

github-project-automation bot added this to AppModel Feb 13, 2026

Copilot started work on behalf of agocke February 13, 2026 18:44 View session

jkotas added the runtime-async label Feb 13, 2026

github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 13, 2026

Enable runtime-async for System.IO.Compression and System.IO.Compress…

22e14cf

…ion.Brotli Co-authored-by: agocke <515774+agocke@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Enable runtime async for System.Compression performance testing~~ Enable runtime-async for System.IO.Compression and System.IO.Compression.Brotli Feb 13, 2026

Copilot AI requested a review from agocke February 13, 2026 19:17

Copilot finished work on behalf of agocke February 13, 2026 19:17

github-actions bot added area-System.IO.Compression and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Feb 13, 2026

Enable runtime-async for System.Net.WebSockets; fix preview feature p…

06236ed

…ropagation for all three libraries Co-authored-by: agocke <515774+agocke@users.noreply.github.com>

Copilot AI changed the title ~~Enable runtime-async for System.IO.Compression and System.IO.Compression.Brotli~~ Enable runtime-async for System.IO.Compression, System.IO.Compression.Brotli, and System.Net.WebSockets Feb 14, 2026

Copilot finished work on behalf of agocke February 14, 2026 00:22

build-analysis bot mentioned this pull request Feb 14, 2026

Sometimes the helix SDK uses GetWorkItemsAsync when workitems aren't done processing. dotnet/dnceng#6011

Open

3 tasks

iremyux removed the area-System.IO.Compression label Feb 19, 2026

github-actions bot added the area-System.IO.Compression label Feb 19, 2026

rzikm added area-VM-coreclr and removed area-System.IO.Compression labels Feb 20, 2026

Merge remote-tracking branch 'upstream/main' into copilot/enable-runt…

0f3d88f

…ime-async-compression

agocke reviewed Mar 10, 2026

View reviewed changes

Copilot started work on behalf of agocke March 10, 2026 17:20 View session

Remove NoWarn CA2252 from compression libraries and revert WebSockets…

766c789

… changes Co-authored-by: agocke <515774+agocke@users.noreply.github.com>

Copilot AI changed the title ~~Enable runtime-async for System.IO.Compression, System.IO.Compression.Brotli, and System.Net.WebSockets~~ Enable runtime-async for System.IO.Compression and System.IO.Compression.Brotli Mar 10, 2026

Copilot AI requested a review from agocke March 10, 2026 17:27

Copilot finished work on behalf of agocke March 10, 2026 17:27

Conversation

Copilot AI commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

agocke commented Feb 13, 2026

Uh oh!

pr-benchmarks bot commented Feb 13, 2026

Uh oh!

pr-benchmarks bot commented Feb 13, 2026

Uh oh!

pr-benchmarks bot commented Feb 13, 2026

Uh oh!

agocke commented Feb 13, 2026

Uh oh!

pr-benchmarks bot commented Feb 13, 2026

Uh oh!

pr-benchmarks bot commented Feb 13, 2026

Uh oh!

pr-benchmarks bot commented Feb 13, 2026

Uh oh!

pr-benchmarks bot commented Feb 13, 2026

Uh oh!

agocke commented Feb 13, 2026

Uh oh!

pr-benchmarks bot commented Feb 13, 2026

Uh oh!

pr-benchmarks bot commented Feb 13, 2026

Uh oh!

pr-benchmarks bot commented Feb 13, 2026

Uh oh!

pr-benchmarks bot commented Feb 13, 2026

Uh oh!

agocke commented Feb 13, 2026

Uh oh!

pr-benchmarks bot commented Feb 13, 2026

Uh oh!

pr-benchmarks bot commented Feb 13, 2026

Uh oh!

Copilot AI commented Feb 14, 2026

Uh oh!

agocke commented Feb 17, 2026

Uh oh!

pr-benchmarks bot commented Feb 17, 2026

Uh oh!

pr-benchmarks bot commented Feb 17, 2026

Uh oh!

iremyux commented Feb 19, 2026

Uh oh!

agocke commented Feb 19, 2026

Uh oh!

agocke commented Feb 19, 2026

Uh oh!

DrewScoggins commented Feb 19, 2026

Uh oh!

dotnet-policy-service bot commented Feb 20, 2026

Uh oh!

agocke Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Copilot AI commented Feb 13, 2026 •

edited

Loading