Try using unordered_map hash in DacInstanceManager#123737
Open
hoyosjs wants to merge 4 commits intodotnet:mainfrom
Open
Try using unordered_map hash in DacInstanceManager#123737hoyosjs wants to merge 4 commits intodotnet:mainfrom
hoyosjs wants to merge 4 commits intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
This was referenced Jan 29, 2026
Open
am11
reviewed
Jan 30, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR switches DacInstanceManager’s instance lookup structure to the std::unordered_map-based implementation by default, and updates the custom hashing hook to avoid reliance on non-portable hash_compare.
Changes:
- Disable the hand-rolled DAC hashtable by default (
DAC_HASHTABLE) so the unordered_map path is used. - Replace
std::hash_compare-based hashing with a portable unary hash functor forstd::unordered_map. - Minor cleanup in
daccess.cpp(reference declaration simplification; remove unused local).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/coreclr/debug/daccess/dacimpl.h |
Switches default to unordered_map and replaces the hasher implementation with a portable functor. |
src/coreclr/debug/daccess/daccess.cpp |
Small cleanups in the unordered_map codepath (reference syntax; remove unused variable). |
Member
Author
|
/backport to release/8.0 |
Contributor
|
Started backporting to |
4 tasks
…s/runtime into juhoyosa/dacinstance_hash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.