Update to draft 14 of Composite ML-DSA #123106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the implementation to align with draft 14 of the Composite ML-DSA specification by adding support for context-aware signatures. The changes expand test coverage to verify both context and non-context signature scenarios.
Changes:
- Added context parameter support to signature verification tests
- Updated test vectors to include context data and context-aware signatures
- Parameterized existing tests to exercise both context and non-context code paths
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| CompositeMLDsaTestsBase.cs | Added parameterized test data to test both context and non-context signature verification paths, updated test methods to use context parameter |
| CompositeMLDsaTestData.cs | Extended test vector structure to include context data and context-aware signature fields |
bartonjs
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #123097
Code used to regenerate the test vectors from the IETF reference vectors: https://gist.github.com/PranavSenthilnathan/6317f3c83aa7d91874f08fe2763210cc