-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Replace hardcoded macOS Helix queue names with centralized variables #123083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: matouskozak <55735845+matouskozak@users.noreply.github.com>
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR aims to replace hardcoded macOS Helix queue names with centralized variable references in iOS/tvOS/MacCatalyst Helix queue configurations to enable single-point-of-update for macOS version changes.
Changes:
- Replace
OSX.15.Arm64.Openwith$(helix_macos_arm64)for iOS/tvOS simulators and MacCatalyst ARM64 - Replace
OSX.15.Amd64.Openwith$(helix_macos_x64)for iOS/tvOS simulators and MacCatalyst x64 - Replace
osx.15.amd64.iphone.openwith$(helix_macos_ios_device_latest)for iOS devices - Replace
osx.15.amd64.appletv.openwith$(helix_macos_tvos_device_latest)for tvOS devices
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| eng/pipelines/libraries/helix-queues-setup.yml | Replace 4 hardcoded macOS queue names with variable references for iOS/tvOS simulators, MacCatalyst, and iOS/tvOS devices |
| eng/pipelines/coreclr/templates/helix-queues-setup.yml | Replace 4 hardcoded macOS queue names with variable references for iOS/tvOS simulators, MacCatalyst, and iOS/tvOS devices |
|
/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Co-authored-by: matouskozak <55735845+matouskozak@users.noreply.github.com>
|
/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Description
Replaced hardcoded macOS queue names with centralized variable references in iOS/tvOS/MacCatalyst Helix queue configurations. This enables single-point-of-update for macOS version changes across the entire repository.
Files Modified:
eng/pipelines/libraries/helix-queues-setup.ymleng/pipelines/coreclr/templates/helix-queues-setup.ymleng/pipelines/runtime-ioslike.ymleng/pipelines/runtime-ioslikesimulator.ymleng/pipelines/runtime-maccatalyst.ymlReplacements:
OSX.15.Arm64.Open→$(helix_macos_arm64)(iOS/tvOS simulators, MacCatalyst ARM64) - upgrades to macOS 26OSX.15.Amd64.Open→$(helix_macos_x64)(iOS/tvOS simulators, MacCatalyst x64)osx.15.amd64.iphone.open→$(helix_macos_ios_device_latest)(iOS devices)osx.15.amd64.appletv.open→$(helix_macos_tvos_device_latest)(tvOS devices)Pipeline Updates:
helix-platforms.ymltemplate include to runtime-ioslike.yml, runtime-ioslikesimulator.yml, and runtime-maccatalyst.yml to ensure helix platform variables are available when these pipelines are triggered directly via/azp runcommands.All variables are defined in
eng/pipelines/helix-platforms.ymland resolve to the same or updated queue values.Customer Impact
None. Infrastructure change only.
Regression
No. This is a refactoring to improve maintainability.
Testing
YAML syntax validation confirmed. No functional changes to pipeline behavior.
Risk
Low. Direct variable substitution with existing centralized definitions. All affected pipelines now include
helix-platforms.ymlto ensure variables are properly resolved.This pull request was created from Copilot chat.
>
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.