Fix another Uri debug assert #123075
Merged
Fix another Uri debug assert #123075
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Tagging subscribers to this area: @dotnet/ncl |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a debug assertion failure that occurs when processing URIs with empty paths in the UriFormat.Unescaped code path. The issue arises because the Overlaps method can incorrectly report that an empty span doesn't overlap with a buffer, even though the operation is valid.
Changes:
- Modified debug assertion in
Uri.csto handle empty spans correctly - Added test assertions to verify
AbsolutePathandLocalPathproperties for an FTP URI with a compressed path
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/libraries/System.Private.Uri/src/System/Uri.cs | Fixed debug assertion to check if span is empty before calling Overlaps |
| src/libraries/System.Private.Uri/tests/FunctionalTests/UriRelativeResolutionTest.cs | Added test assertions to exercise the UriFormat.Unescaped code path with an empty path |
ManickaP
approved these changes
Jan 12, 2026
This was referenced Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overlapsspecial-cases empty spans as not overlapping even if the pointer appears in the middle.In this case, the
LocalPathtest exercises theUriFormat.Unescapedcode path.