Mark async CapacityTests as GC stress incompatible #123032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jakobbotsch <7887810+jakobbotsch@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Mark async CapacityTests as GC stress incompatible
Mark async CapacityTests as GC stress incompatible
Jan 9, 2026
Member
|
@copilot Please also mark |
Co-authored-by: jakobbotsch <7887810+jakobbotsch@users.noreply.github.com>
Contributor
Author
Done in 629fd37. |
jakobbotsch
approved these changes
Jan 9, 2026
VSadov
approved these changes
Jan 9, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR marks three async capacity test methods as incompatible with GC stress testing modes. The tests dynamically generate types with thousands of methods (40,000 int-returning methods and 32,750+ Task-returning methods), which cause issues under GC stress conditions.
Key Changes
- Added
[SkipOnCoreClr("", RuntimeTestModes.AnyGCStress)]attributes to three test methods - All changes are test infrastructure improvements with no functional code modifications
- Follows established patterns used throughout the test suite for similar scenarios
This was referenced Jan 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
[SkipOnCoreClr("", RuntimeTestModes.AnyGCStress)]to all three test methods insrc/tests/async/capacity/capacity.cs:TestLargeClassWithIntMethods(40,000 methods returningint)TestLargeClassWithTaskMethods_Success(32,750 methods returningTask)TestLargeClassWithTaskMethods_Exception(32,763 methods returningTask)All tests dynamically generate types with large numbers of methods, which are incompatible with GC stress modes.
Customer Impact
None. Test infrastructure change only.
Regression
No.
Testing
Follows existing pattern for marking tests incompatible with GC stress (see
src/tests/JIT/jit64/opt/cse/HugeArray.csand similar).Risk
Low. Test-only change using established attribute pattern.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.