Do not ship EventSourceGenerator #123000
Do not ship EventSourceGenerator #123000
Conversation
#121180 said this was internal, so we shouldn't include it in the ref pack.
There was a problem hiding this comment.
Pull request overview
This PR removes EventSourceGenerator from the list of generators shipped in the .NET Core App reference pack, treating it as an internal-only tool as determined in issue #121180.
Key Changes
- Remove EventSourceGenerator from the
NetCoreAppLibraryGeneratorlist in NetCoreAppLibrary.props
|
Make sure to account for this in the VMR. When this was accidentally included, some EventSource types were adjusted to handle this generator being in the ref pack. |
Looking at the dotnet/dotnet PR that integrated it, looks like the fallout was mostly about adding |
|
SDK has tests that were impacted. We'll need to undo those when this flows to SDK again. FWIW this was packed as a language agnostic generator (with F# support too). Not sure if that was intended or not, most likely not. But if folks were to decide to ship this we'd need to correct the value of AnalyzerLanguage. |
#121180 said this was internal, so we shouldn't include it in the ref pack.