Add diagnostics, escapes, and typedefs to C# ilasm #122930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement several features for the C# ilasm replacement: - Add diagnostic reporting infrastructure with 20 diagnostic IDs and helper methods (ReportError, ReportWarning, ReportDiagnostic) - Add escape sequence parsing in StringHelpers.ParseQuotedString supporting \t, \n, \r, \\, \", octal sequences, etc. - Add typedef support: store and resolve type/member/custom attribute aliases via .typedef declarations - Fix IndexOutOfRangeException when field has no marshal clause - Add tests for typedefs, escape sequences, and diagnostics
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT |
jkoritzinsky
reviewed
Jan 6, 2026
Member
jkoritzinsky
left a comment
There was a problem hiding this comment.
Looking good so far! Can we add tests for more of the error diagnostics?
src/tools/ilasm/tests/ILAssembler.Tests/DocumentCompilerTests.cs
Outdated
Show resolved
Hide resolved
jkoritzinsky
approved these changes
Jan 6, 2026
This was referenced Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement several features for the C# ilasm replacement:
Add diagnostic reporting infrastructure with 20 diagnostic IDs and helper methods (ReportError, ReportWarning, ReportDiagnostic)
Add escape sequence parsing in StringHelpers.ParseQuotedString supporting \t, \n, \r, \, ", octal sequences, etc.
Add typedef support: store and resolve type/member/custom attribute aliases via .typedef declarations
Fix IndexOutOfRangeException when field has no marshal clause
Add tests for typedefs, escape sequences, and diagnostics