Change TypeMapLazyDictionary to use direct cast instead of 'as' operator for RuntimeAssembly #122885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…untimeAssembly Co-authored-by: jtschuster <36744439+jtschuster@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update LazyTypeMapDictionary to cast to RuntimeAssembly
Change TypeMapLazyDictionary to use direct cast instead of 'as' operator for RuntimeAssembly
Jan 5, 2026
jtschuster
approved these changes
Jan 5, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes the type conversion approach from the as operator to a direct cast for converting Assembly to RuntimeAssembly? in the TypeMapLazyDictionary.CreateMaps() method. The change affects two calls: Assembly.Load(string) and Assembly.GetEntryAssembly().
Key Changes:
- Changed
Assembly.Load(entryAssemblyName) as RuntimeAssemblyto(RuntimeAssembly?)Assembly.Load(entryAssemblyName) - Changed
Assembly.GetEntryAssembly() as RuntimeAssemblyto(RuntimeAssembly?)Assembly.GetEntryAssembly()
This was referenced Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced
as RuntimeAssemblywith direct cast(RuntimeAssembly?)inTypeMapLazyDictionary.CreateMaps()for bothAssembly.Load()andAssembly.GetEntryAssembly()calls.Direct cast surfaces type mismatches as
InvalidCastExceptionrather than silently returning null, which is the correct behavior since these methods should always returnRuntimeAssemblywhen non-null in the runtime environment.Customer Impact
None. This is a code quality improvement addressing review feedback.
Regression
No.
Testing
Existing System.Runtime.InteropServices test suite (2547 tests passed).
Risk
Low. Minimal change to type conversion semantics with identical behavior for valid inputs.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.