JIT: Disallow tailcall stress in async methods #122869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicit tailcalls are not allowed out of async methods so it does not make sense to allow turning on tailcall stress. Turning it on also impacts IR created because we we may skip creating some `GT_RETURN` nodes, which is not expected by async transformations.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #122632 by disabling tailcall stress mode for async methods. Since explicit tailcalls are not allowed out of async methods (they need to restore contexts), it doesn't make sense to enable tailcall stress mode in these methods. Enabling tailcall stress in async methods can also cause issues with IR creation, as some GT_RETURN nodes may be skipped, which is not expected by async transformations.
Key Changes
- Added
!compIsAsync()check tocompTailCallStress()to prevent tailcall stress mode from being enabled in async methods - Added explanatory comment documenting why tailcalls are not allowed in async methods
Member
Author
|
PTAL @dotnet/jit-contrib |
AndyAyersMS
approved these changes
Jan 5, 2026
Member
Author
|
/ba-g iOS dead letter |
This was referenced Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicit tailcalls are not allowed out of async methods so it does not make sense to allow turning on tailcall stress. Turning it on also impacts IR created because we we may skip creating some
GT_RETURNnodes, which is not expected by async transformations.Fix #122632