Skip to content

Use /O2 for Windows x86 Checked #122846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jkotas merged 1 commit into from
Jan 4, 2026
Merged

Use /O2 for Windows x86 Checked #122846

jkotas merged 1 commit into from
Jan 4, 2026

Conversation

@huoyaoyuan
Copy link
Member

@huoyaoyuan huoyaoyuan commented Jan 4, 2026 •
edited
Loading

Fixes #59845. Contributes to #53849.

The failing asserts were specific to legacy EH.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jan 4, 2026
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jan 4, 2026
@huoyaoyuan huoyaoyuan added area-Infrastructure-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jan 4, 2026
jkotas
jkotas approved these changes Jan 4, 2026
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas
Copy link
Member

jkotas commented Jan 4, 2026

/ba-g deadletter

@jkotas jkotas merged commit 5415a58 into dotnet:main Jan 4, 2026
155 of 158 checks passed
@huoyaoyuan huoyaoyuan deleted the windows-x86-o1 branch January 4, 2026 06:19
This was referenced Jan 9, 2026
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkotas jkotas jkotas approved these changes

Assignees

No one assigned

Labels

area-Infrastructure-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

Runtime Infra
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Windows x86 Checked CLR build using -O2 hits runtime asserts

2 participants

@huoyaoyuan @jkotas