Skip to content

Fix debug build #122753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jkotas merged 1 commit into from
Dec 27, 2025
Merged

Fix debug build #122753

jkotas merged 1 commit into from
Dec 27, 2025

Conversation

@am11
Copy link
Member

@am11 am11 commented Dec 27, 2025

/Users/adeel/projects/runtime5/src/coreclr/System.Private.CoreLib/src/System/Threading/Interlocked.CoreCLR.cs(149,9): error IDE0036: Modifiers are not ordered (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0036) [/Users/adeel/projects/runtime5/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]

@am11 am11 requested a review from jkoritzinsky December 27, 2025 12:52
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Dec 27, 2025
@am11 am11 requested a review from jkotas December 27, 2025 12:52
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Dec 27, 2025
@am11 am11 removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Dec 27, 2025
@am11 am11 mentioned this pull request Dec 27, 2025
Merged
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Dec 27, 2025

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@build-analysis build-analysis bot mentioned this pull request Dec 27, 2025
Open
jkotas
jkotas approved these changes Dec 27, 2025
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas jkotas merged commit 2c8bf45 into dotnet:main Dec 27, 2025
102 of 104 checks passed
@am11 am11 deleted the patch-47 branch December 27, 2025 17:30
This was referenced Jan 9, 2026
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkotas jkotas jkotas approved these changes

@jkoritzinsky jkoritzinsky Awaiting requested review from jkoritzinsky

Assignees

No one assigned

Labels

area-System.Threading community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@am11 @jkotas