[clr-interp] Fix regression caused by my recent changes #122655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
davidwrighton
commented
Dec 19, 2025
- The HasUnmanagedCallersOnlyAttribute api is... not as accurate as I'd like. See comment in the code
- The HasUnmanagedCallersOnlyAttribute api is... not as accurate as I'd like. See comment in the code
Contributor
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a regression in the CoreCLR interpreter by refining the logic for detecting methods with the UnmanagedCallersOnlyAttribute. The fix addresses an issue where HasUnmanagedCallersOnlyAttribute() returns true for IL stubs even though they don't actually have the attribute.
Key Changes:
- Added an additional check to exclude IL stubs when testing for
UnmanagedCallersOnlyAttribute - Added a clarifying comment explaining the inaccuracy of the
HasUnmanagedCallersOnlyAttribute()API
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
BrzVlad
approved these changes
Dec 19, 2025
kotlarmilos
approved these changes
Dec 19, 2025
This was referenced Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.