-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[release/8.0-staging] Update OpenSSL dependency for openSUSE and SLES #122654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0-staging] Update OpenSSL dependency for openSUSE and SLES #122654
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the OpenSSL dependency for SLES and openSUSE distributions from older versions to libopenssl3, which is now supported and installed by default on all currently supported distro releases including openSUSE Tumbleweed.
Key Changes
- Updates SLES 12 dependency from
libopenssl1_1tolibopenssl3 - Updates openSUSE 42 dependency from
libopenssl1_0_0tolibopenssl3
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/installer/pkg/sfx/installers/dotnet-runtime-deps/dotnet-runtime-deps-sles.12.proj |
Updates OpenSSL dependency from libopenssl1_1 to libopenssl3 for SLES |
src/installer/pkg/sfx/installers/dotnet-runtime-deps/dotnet-runtime-deps-opensuse.42.proj |
Updates OpenSSL dependency from libopenssl1_0_0 to libopenssl3 for openSUSE |
After thorough review, I found no issues with this PR. The changes are straightforward dependency updates that align with the PR description and the linked issue. The file names (sles.12 and opensuse.42) represent the package target OS identifiers used by the .NET installer infrastructure, not literal version restrictions. According to the PR description, libopenssl3 is available and installed by default on all currently supported SLES and openSUSE releases, making these updates appropriate.
|
@jkoritzinsky @richlander this was approved for next servicing release. Can you review/approve it? |
|
Thanks @jkoritzinsky! @hoyosjs @jkoritzinsky who has permissions to merge this on red? Or perhaps I should merge with target branch and rerun the checks? @rbhanda this should ship in next servicing release. |
|
OSX legs are failing in other PRs as well - this is unrelated to my changes. |
2331020
into
dotnet:release/8.0-staging
Fixes: #122653
libopenssl3is supported and installed by default on all of the supported distro releases listed at https://learn.microsoft.com/en-us/dotnet/core/install/linux-sles?tabs=dotnet8 and https://learn.microsoft.com/en-us/dotnet/core/install/linux-opensuse?tabs=dotnet8libopenssl3is also supported and installed by default on openSUSE Tumbleweed release. This release does not have any other, older, version of this library.