Skip to content

Conversation

@kotlarmilos
Copy link
Member

@kotlarmilos kotlarmilos commented Dec 17, 2025

Description

This PR enables CoreCLR tests for tvOS in the extra-platforms pipelines.

Contributes to #120055

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Dec 17, 2025
@kotlarmilos kotlarmilos changed the title [clr-ios] Enable CoreCLR tests for tvOS and maccaalyst x64 in extra-platforms [clr-ios] Enable CoreCLR tests for tvOS and maccatalyst x64 in extra-platforms Dec 17, 2025
@kotlarmilos kotlarmilos added os-ios Apple iOS area-CodeGen-Interpreter-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Dec 17, 2025
@kotlarmilos kotlarmilos added this to the 11.0.0 milestone Dec 17, 2025
@kotlarmilos
Copy link
Member Author

/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @BrzVlad, @janvorli, @kg
See info in area-owners.md if you want to be subscribed.

@kotlarmilos
Copy link
Member Author

/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@kotlarmilos
Copy link
Member Author

/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@kotlarmilos
Copy link
Member Author

/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@kotlarmilos
Copy link
Member Author

/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@kotlarmilos kotlarmilos changed the title [clr-ios] Enable CoreCLR tests for tvOS and maccatalyst x64 in extra-platforms [clr-ios] Enable CoreCLR tests for tvOS in extra-platforms Dec 17, 2025
@kotlarmilos kotlarmilos marked this pull request as ready for review December 17, 2025 21:21
Copilot AI review requested due to automatic review settings December 17, 2025 21:21
@kotlarmilos
Copy link
Member Author

/azp run runtime-ioslike

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables CoreCLR tests for tvOS in the extra-platforms pipelines, contributing to issue #120055. The changes include runtime support modifications for tvOS's unique platform constraints and pipeline configuration updates.

Key changes:

  • Added tvOS-specific pthread synchronization support to handle platform limitations where Mach exceptions and System V IPC are unavailable
  • Enabled FEATURE_STUBPRECODE_DYNAMIC_HELPERS for tvOS in CMake configuration
  • Updated pipeline configurations to run CoreCLR tests on both tvOS simulator and device platforms

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/coreclr/pal/src/thread/process.cpp Removed trailing whitespace
src/coreclr/pal/src/include/pal/threadsusp.hpp Added tvOS support to use pthread condition variables for thread synchronization since System V semaphores are unavailable
src/coreclr/clrfeatures.cmake Extended FEATURE_STUBPRECODE_DYNAMIC_HELPERS to include tvOS alongside iOS and MacCatalyst
eng/pipelines/extra-platforms/runtime-extra-platforms-ioslikesimulator.yml Enabled tvossimulator_arm64 platform for CoreCLR runtime and library tests
eng/pipelines/extra-platforms/runtime-extra-platforms-ioslike.yml Enabled tvos_arm64 platform for CoreCLR tests while temporarily disabling ios_arm64 due to separate Helix queue upgrade issue

Copy link
Member

@vitek-karas vitek-karas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good...

@kotlarmilos kotlarmilos merged commit e846322 into dotnet:main Dec 18, 2025
175 of 182 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants