[Wasm RyuJit] unordered floating point compares #122562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wasm floating point comparisons (except `fne`) return false if any operand is a NaN. Handle unordered compares by reversing the comparison and branching if the result is false.
Member
Author
|
@dotnet/jit-contrib PTAL |
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
SingleAccretion
approved these changes
Dec 16, 2025
adamperlin
approved these changes
Dec 16, 2025
Contributor
adamperlin
left a comment
There was a problem hiding this comment.
This looks good to me! Thanks for the comments on unordered EQ/ordered NE @SingleAccretion!
This was referenced Jan 9, 2026
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wasm floating point comparisons (except
fne) return false if any operand is a NaN. Handle unordered compares by reversing the comparison and branching if the result is false.