Fix build with GVM_RESOLUTION_TRACE
#122496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fallout from the UTF-8 changes.
Contributor
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a build break when compiling with the GVM_RESOLUTION_TRACE conditional compilation flag enabled. The issue was caused by recent UTF-8 changes that modified how method names are accessed in the type system. The Name property now returns ReadOnlySpan<byte> instead of string, and a new GetName() method was introduced to get the string representation.
- Updated two debug trace statements to use the new
GetName()method instead of the deprecatedNameproperty - Changes are isolated to conditional compilation blocks that are not built by default
jkotas
approved these changes
Dec 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fallout from the UTF-8 changes.
Cc @dotnet/ilc-contrib