Skip failing COM test #122474
Merged
Skip failing COM test #122474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Tagging subscribers to this area: @dotnet/interop-contrib |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR skips a failing COM interop test to address issue #122447. The test GetSameComInterfaceTwiceReturnsUniqueInstances has been marked with the Skip parameter and wrapped with pragma directives to suppress xUnit warning xUnit1004 (which flags skipped test methods).
Key Changes
- Added
Skipparameter to theConditionalFactattribute with a reference to the GitHub issue explaining the test construction problem - Wrapped the test attribute with
#pragma warning disable/restore xUnit1004directives to suppress the warning about skipped tests
...untime.InteropServices/tests/LibraryImportGenerator.Tests/NativeMarshallingAttributeTests.cs
Show resolved
Hide resolved
jkotas
approved these changes
Dec 12, 2025
stephentoub
approved these changes
Dec 12, 2025
Member
Author
|
/ba-g failures are unrelated wasm tests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skips the test causing #122447