Fix compiling HWIntrinsic fallbacks #122463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I changed how we do HWIntrinsic support for platforms that don't have JIT, I missed that crossgen2 explicitly skips pre-jitting the fallback methods. Adjust crossgen2 to not skip them when the target can't JIT.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in crossgen2 where hardware intrinsic fallback methods were incorrectly being skipped during AOT compilation for platforms that don't support runtime JIT compilation (iOS, tvOS, MacCatalyst, WebAssembly). The fix ensures that fallback implementations are compiled when the target platform cannot generate code at runtime, making them available to the interpreter.
Key changes:
- Modified the
ShouldSkipCompilationmethod to check if the target allows runtime code generation before skipping hardware intrinsic methods - Hardware intrinsic methods are now only skipped if they are hardware intrinsics and the target platform supports runtime JIT
elinor-fung
approved these changes
Dec 11, 2025
src/coreclr/tools/aot/ILCompiler.ReadyToRun/JitInterface/CorInfoImpl.ReadyToRun.cs
Show resolved
Hide resolved
This was referenced Dec 11, 2025
Member
Author
|
/ba-g networking problems in unrelated legs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I changed how we do HWIntrinsic support for platforms that don't have JIT, I missed that crossgen2 explicitly skips pre-jitting the fallback methods. Adjust crossgen2 to not skip them when the target can't JIT.