Always pass -UseBasicParsing for Invoke-WebRequest calls in powershell #122439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds the -UseBasicParsing parameter to all Invoke-WebRequest calls in repository-specific PowerShell scripts and Dockerfiles, addressing issue #122393. The -UseBasicParsing parameter ensures that the cmdlet doesn't depend on Internet Explorer's DOM parser, making the scripts more reliable and portable across different environments.
Key changes:
- Updated all
Invoke-WebRequestcalls to include-UseBasicParsingparameter - Changes span across WASI bindings generation scripts, stress test build scripts, Python scripts embedding PowerShell, and Docker configuration files
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/libraries/System.Private.CoreLib/src/System/Threading/Wasi/generate-wasi-poll-bindings.ps1 | Added -UseBasicParsing to Invoke-WebRequest for downloading wasi-http archive |
| src/libraries/System.Net.Http/src/System/Net/Http/WasiHttpHandler/generate-wasi-http-bindings.ps1 | Added -UseBasicParsing to Invoke-WebRequest for downloading wasi-http archive |
| src/libraries/Common/tests/System/Net/StressTests/build-local.ps1 | Added -UseBasicParsing to Invoke-WebRequest for downloading dotnet-install script |
| src/coreclr/scripts/superpmi_aspnet2.py | Added -UseBasicParsing to Invoke-WebRequest in embedded PowerShell command for SDK installation |
| eng/docker/libraries-sdk.windows.Dockerfile | Added -UseBasicParsing to Invoke-WebRequest for downloading dotnet-install script in Docker build |
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
This was referenced Dec 11, 2025
Open
steveisok
approved these changes
Dec 11, 2025
Member
Author
|
/ba-g failures are all on non-Windows platforms and can't be related |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#122393