[clr-interp] Fix dispatch on open virtual delegate with null this #122429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is supposed to throw NullReferenceException. Make it so.
Contributor
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the CoreCLR interpreter where dispatching an open virtual delegate with a null this pointer would cause undefined behavior instead of throwing the expected NullReferenceException. The fix adds an explicit null check before the virtual method dispatch.
Key Changes
- Added
NULL_CHECKfor thethisargument before callingGetMethodDescOfVirtualizedCodein the open virtual delegate dispatch path - Refactored to extract
pThisArgas a local variable, improving code clarity and efficiency - Removed unused lambda captures (
stackandcallArgsOffset)
BrzVlad
approved these changes
Dec 11, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is supposed to throw NullReferenceException. Make it so.
Fixes the GitHub_35000 test.