[RyuJit/WASM] Register allocator skeleton #122414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf539e7 to
19436a5
Compare
This was referenced Dec 11, 2025
Open
c9db6c0 to
a5f251c
Compare
Force all locals to stack and add an interface for the SP/FP. Implement GT_LCL_ADDR / GT_LCL_FLD as samples.
a5f251c to
e12a8cd
Compare
3 tasks
Contributor
Author
|
@dotnet/jit-contrib |
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
AndyAyersMS
approved these changes
Dec 16, 2025
Contributor
Author
|
I have went through the change again and noticed an issue with the |
Member
|
We just took a GUID update so SPMI failures are "expected"... new collections on the way. |
Member
|
Going to give up on trying to get SPMI to pass, this PR should have no impact on it. |
This was referenced Jan 9, 2026
AndyAyersMS
reviewed
Jan 16, 2026
| } | ||
| else | ||
| { | ||
| store = m_compiler->gtNewStoreIndNode(lclNode->TypeGet(), lclNode, lclNode->Data(), indFlags); |
Member
There was a problem hiding this comment.
(post merge note) This is hitting asserts when the local is TYP_LONG as it is not a valid indir addr type... seems like the retyping done below needs to happen earlier?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force all locals to stack and add an interface for the SP/FP.
Implement
GT_LCL_ADDR/GT_LCL_FLDas samples.Next step is to add the stackifier (it'll run before RA and liveness, since it may need to introduce locals and we want to be able to enregister them). After that - parameter homing, and that should bring us to syntactically (if not yet semantically) valid WASM.