sort mscorrc.cpp when building on windows host #122405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-resources |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #122403 by ensuring the generated mscorrc.cpp file has deterministic, sorted output when building on a Windows host. The PowerShell script now sorts resource IDs numerically before generating the C++ array.
Key Changes:
- Added sorting of resource array keys by their numeric value (interpreted as hex) before output generation
- Added explicit hex-to-numeric conversion for consistent formatting
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
radekdoulik
reviewed
Dec 11, 2025
Member
radekdoulik
left a comment
There was a problem hiding this comment.
LGTM, thank you!
This updates the bash counter part #122441
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #122403