[clr-interp] Load/Store peeps deleted expected sequence points from debug data stream #122400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ebug data stream - Add a some logic to have a minor difference between debug and non-debug codegen
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the CoreCLR interpreter where load/store peephole optimizations were incorrectly removing sequence points from the debug data stream. The fix disables these optimizations when compiling with debug code enabled.
- Adds a check to disable store/load peephole optimization in debug builds to preserve sequence points
- The fix is minimal and targeted to the specific peephole optimization that was causing the issue
Contributor
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JIT/Directed/debugging/debuginfo/tester