Fix interpreter INTOP_COMPARE_EXCHANGE_U1 and U2 #122361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation was setting an incorrect value as the return value, which caused the System.Threading.Tasks.Tests.ParallelForEachAsyncTests.AllItemsEnumeratedOnce_For to fail intermittently. There was also a wrong check for alignment of address of the U2 version.
Contributor
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes critical bugs in the interpreter's implementation of 8-bit and 16-bit compare-exchange operations that were causing intermittent test failures.
Key Changes:
- Fixed return value calculation in INTOP_COMPARE_EXCHANGE_U1 and U2 to use the actual compare-exchange result instead of a stale loop variable
- Corrected the alignment check for 16-bit compare-exchange to properly detect misaligned addresses
davidwrighton
approved these changes
Dec 9, 2025
Member
Author
|
/ba-g the linux x64 leg test failure is #122404, unrelated to this change |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation was setting an incorrect value as the return value, which caused the System.Threading.Tasks.Tests.ParallelForEachAsyncTests.AllItemsEnumeratedOnce_For to fail intermittently.
There was also a wrong check for alignment of address of the U2 version.