Fix Double/Single.ConvertToIntegerNative for non-primitive types in interpreter #122342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current logic handles the System.Double/Single.ConvertToIntegerNative always as must expand and fails with NO_WAY if the integer type is not primitive. However, that makes it incorrectly fail e.g. when the integer type is Int128. This change fixes it by using the compiled version of the function for non-primitive types.
Contributor
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the interpreter where System.Double/Single.ConvertToIntegerNative incorrectly fails for non-primitive integer types like Int128. The fix allows these conversions to fall back to the compiled method implementation instead of attempting to expand the intrinsic inline.
Key Changes:
- Modified the intrinsic expansion logic to return
falsefor non-primitive target types instead of jumping to a failure handler - Added explanatory comment documenting why non-primitive types use the compiled method path
3 tasks
davidwrighton
approved these changes
Dec 9, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current interpreter logic handles the
System.Double/Single.ConvertToIntegerNative always as must expand and fails with NO_WAY if the integer type is not primitive. However, that makes it incorrectly fail e.g. when the integer type is Int128.
This change fixes it by using the compiled version of the function for non-primitive types.
It fixes the following libraries tests: