[ilasm] Treat errors in -ERR mode as warnings #122270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The undocumented -ERR mode is meant to ignore errors and allow produce invalid binaries for test purposes. Print the errors as warnings in this mode so that they do not fail the build.
Member
Author
|
Contributes to #122056 |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements a fix for the undocumented -ERR mode in ilasm, which is designed to allow production of invalid binaries for testing purposes. The change ensures that errors are printed as warnings in this mode to prevent build failures.
- Modified the
AsmParse::error()function to output "warning :" instead of "error :" when the-ERRflag is enabled
Member
Author
|
@jkoritzinsky PTLA. We will want to match this in managed ilasm. |
jkoritzinsky
approved these changes
Dec 14, 2025
Member
|
I believe System.Reflection.Metadata allows us to emit invalid-enough stuff to enable these scenarios, so we should be able to replicate this behavior. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The undocumented -ERR mode is meant to ignore errors and allow produce invalid binaries for test purposes. Print the errors as warnings in this mode so that they do not fail the build.