Initial scaffolding and partial implementation of ilasm in C# #122112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l representation we can construct a metadata image from.
…concepts (and some easy cases to knock out now)
…reprocessor. Add some basic tests for the preprocessor
…iversal/easier to use
…ods that we can't implement E2E due to SRM limitations (found some!)
… the MetadataBuilder (including methods).
…efs when possible, correctly handle MethodRefSig scenarios.
…iling) unit test.
This was referenced Dec 5, 2025
jkotas
reviewed
Dec 5, 2025
jkotas
reviewed
Dec 5, 2025
…yet to be exposed.
…lishAot=true, not the backing library (like how we do for crossgen2 and ilc). Mark as IsShipping=false until we are actually ready to ship this.
Member
Author
|
Marking this as ready-for-review as I've done some cleanup and I think this is in a decent state to be experimental in main. |
This was referenced Dec 12, 2025
jkotas
approved these changes
Dec 12, 2025
Member
jkotas
left a comment
There was a problem hiding this comment.
It is hard to review a code bomb like this in details. I have only done a cursory review. LGTM
Member
Author
|
I apologize for the code bomb. My initial intention of finishing this project as a holiday hackathon a few years back and breaking out the work into multiple (more manageable) PRs didn't exactly work out. |
Member
Author
|
/ba-g unrelated timeout in threading tests. |
This was referenced Jan 9, 2026
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start an implementation of ilasm in C# in src/tools/ilasm. ANTLR4 is used to build the grammar.
I decided to structure it as a library (with a frontend to come later) to match ILVerify/ILVerification.
This implementation is far from complete. The grammar is missing any updates from the last year or two and much is untested and unimplemented.
It has one passing test for a simple case so far.
Putting out a PR now so other team members and community members can work on it.
Contributes to #121847