AOT publish passes with long paths on Windows #121956
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses the fix for issue #103625 by removing the workaround for long path failures on Windows during AOT publish and adding a dedicated test to verify the fix.
- Removed commented-out active issue annotation and explanatory comments about long path limitations
- Added a new test
DefaultTemplate_AOT_WithLongPaththat explicitly creates a project with a long path and performs AOT publish to ensure it works correctly
am11
reviewed
Nov 25, 2025
This was referenced Nov 26, 2025
pavelsavara
reviewed
Nov 28, 2025
pavelsavara
reviewed
Nov 28, 2025
jkotas
reviewed
Nov 28, 2025
This was referenced Dec 1, 2025
Open
pavelsavara
reviewed
Dec 10, 2025
Member
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
|
This was referenced Jan 2, 2026
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jan 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103625.
This PR fixes Windows MAX_PATH (260 character) limitation in WASM AOT compilation by adding
\\?\prefix support to long file paths across the Mono runtime's file operations.Long path prefix comes from Unicode “W” APIs. Windows versions from Windows NT on support that API.
OSs that do not support this change:
Changes:
gpath.c: Adds
g_path_make_long_compatible()helper function that conditionally adds\\?\prefix to Windows paths ≥260 characters, supporting both regular absolute paths (C:\path→\\?\C:\path) and UNC network paths (\\server\share→\\?\UNC\server\share).mono-path.c: Uses
g_path_make_long_prefix()inmono_path_canonicalize()to ensure canonicalized paths support long path operations.image.c: Uses the canonicalized absolute path (
absfname) instead of the original filename when loading assemblies to ensure long paths are handled correctly throughout the image loading process.MonoAOTCompiler.cs: Passes full absolute paths to the AOT compiler instead of potentially relative paths to ensure Windows long path support (
\\?\prefix from canonicalization) works correctly.gfile-win32.c: Calls
g_path_make_long_compatible()ing_file_test()before callingGetFileAttributesW()to enable existence checks for files with long paths.gfile.c: Calls
g_path_make_long_compatible()ing_fopen()before opening files to support long paths when the runtime needs to open assembly files.BuildPublishTests.cs: Adds
DefaultTemplate_AOT_WithLongPathtest with 300+ character path prefix to verify long path support works correctly with AOT compilation.