Haiku: Process/thread management functions by trungnt2910 · Pull Request #121883 · dotnet/runtime

trungnt2910 · 2025-11-21T15:01:25Z

Add support for process/thread management functions in System.Diagnostics.Process for Haiku.

This is required to build managed runtime libraries for Haiku as well as running a simple "Hello, World!" application.

Part of #55803.

trungnt2910 · 2025-11-21T15:02:23Z

C/c @am11

I just added the relevant parts of the common files to both, then we can rebase stuff later.

Copilot

Pull request overview

This PR adds Haiku operating system support to the System.Diagnostics.Process library, enabling process and thread management functionality for Haiku. This is part of the broader effort to support Haiku as a platform (#55803).

Implements Haiku-specific process/thread management APIs using native Haiku system calls
Adds proper platform attribute annotations for API surface compatibility
Integrates Haiku interop layer for process, thread, and image information

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`ProcessThread.cs`	Adds `[SupportedOSPlatform("haiku")]` attributes to `PriorityLevel` property getter and setter
`ProcessThread.Haiku.cs`	Implements Haiku-specific thread priority management and processor time tracking using native BeOS-style priority values
`ProcessManager.Haiku.cs`	Implements process enumeration, module collection, and process information retrieval for Haiku using team and thread APIs
`Process.cs`	Adds `[UnsupportedOSPlatform("haiku")]` attributes to working set limit properties
`Process.Haiku.cs`	Implements Haiku-specific process properties including boot time caching, start time, processor time tracking, and platform-specific helper methods
`System.Diagnostics.Process.csproj`	Adds Haiku target framework and includes Haiku-specific source files and interop definitions
`Interop.OS.cs`	Defines Haiku native interop for OS-level APIs including team/thread/area/system information structures and P/Invoke declarations
`Interop.Libraries.cs`	Defines the `libroot` library constant for Haiku native library imports
`Interop.Image.cs`	Defines Haiku native interop for image (module) information APIs

Copilot · 2025-11-21T15:11:31Z

src/libraries/System.Diagnostics.Process/src/System/Diagnostics/ProcessThread.cs

@@ -100,6 +101,7 @@ public ThreadPriorityLevel PriorityLevel
                return _priorityLevel.Value;
            }
            [SupportedOSPlatform("windows")]


The setter is missing [SupportedOSPlatform("linux")] and [SupportedOSPlatform("freebsd")] attributes. While these platforms throw PlatformNotSupportedException in their implementations, the attributes on the public API should match the getter's attributes to maintain consistency and accuracy in the API surface declarations. The presence of the getter attribute for these platforms indicates the API should be callable, even if it throws at runtime.

Suggested change

[SupportedOSPlatform("windows")]

[SupportedOSPlatform("windows")]

[SupportedOSPlatform("linux")]

[SupportedOSPlatform("freebsd")]

Ignoring since it's not related to Haiku.

src/libraries/Common/src/Interop/Haiku/Interop.OS.cs

src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.Haiku.cs

src/libraries/Common/src/Interop/Haiku/Interop.Image.cs

trungnt2910 · 2026-02-16T01:26:01Z

Still tracking, will take action soon.

jeffhandley · 2026-02-16T06:38:21Z

@trungnt2910 I pushed 0ee9ed3 to my fork; it merges main into your branch and resolves the conflict. Feel free to cherry-pick that commit if it's helpful.

Add support for process/thread management functions in `System.Diagnostics.Process` for Haiku. This is required to build managed runtime libraries for Haiku as well as running a simple "Hello, World!" application. Co-authored-by: Jessica Hamilton <jessica.l.hamilton@gmail.com>

Declare Haiku as a supported platform to MSBuild for all `System.Diagnostics.Process` builds. This prevents `CA1418` when using the `SupportedOSPlatform` attribute with `haiku`.

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 5 comments.

src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.Haiku.cs

src/libraries/System.Diagnostics.Process/src/System/Diagnostics/ProcessManager.Haiku.cs

src/native/libs/configure.cmake

src/native/libs/System.Native/pal_getosinfo.c

src/libraries/Common/src/Interop/Haiku/Interop.OS.cs

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 5 comments.

Copilot · 2026-04-11T11:59:47Z

src/libraries/System.Diagnostics.Process/src/System/Diagnostics/ProcessManager.Haiku.cs

+
+            while ((Interop.Image.GetNextImageInfo(processId, ref cookie, out info)) == 0)
+            {
+                string modulePath = GetString(info.name, Interop.Image.MAXPATHLEN);


In GetModules, info.name is a fixed buffer field; it can’t be passed directly to a byte* parameter. This likely won’t compile. Use a fixed (byte* pName = info.name) block (or change GetString to accept a span) and pass the pinned pointer.

Suggested change

string modulePath = GetString(info.name, Interop.Image.MAXPATHLEN);

string modulePath;

fixed (byte* pName = info.name)

{

modulePath = GetString(pName, Interop.Image.MAXPATHLEN);

}

Haven't seen any errors so far.

src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.Haiku.cs

src/libraries/System.Diagnostics.Process/src/System/Diagnostics/ProcessManager.Haiku.cs

src/libraries/Common/src/Interop/Haiku/Interop.OS.cs

src/libraries/Common/src/Interop/Haiku/Interop.Image.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.

src/native/libs/System.Native/pal_getosinfo.c

src/libraries/System.Diagnostics.Process/src/System/Diagnostics/ProcessManager.Haiku.cs

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated no new comments.

`System.Collections.Generic` is used by `ArrayBuilder`. I am a victim of Copilot slop.

trungnt2910 · 2026-04-11T13:54:51Z

Local builds are succeeding in both Release and Debug mode (with all my other open PRs on native components applied).

src/libraries/System.Diagnostics.Process/src/System/Diagnostics/ProcessManager.Haiku.cs

Use `ReadOnlySpan` instead of a loop. Co-authored-by: Jan Kotas <jkotas@microsoft.com>

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings November 21, 2025 15:01

github-actions bot added the area-System.Diagnostics.Process label Nov 21, 2025

dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Nov 21, 2025

Copilot started reviewing on behalf of trungnt2910 November 21, 2025 15:02 View session

am11 added the os-haiku label Nov 21, 2025

Copilot finished reviewing on behalf of trungnt2910 November 21, 2025 15:06

Copilot AI reviewed Nov 21, 2025

View reviewed changes

trungnt2910 force-pushed the dev/trungnt2910/haiku-lib-diagnostics branch from 3db3a8c to 822ecd1 Compare November 21, 2025 15:28

huoyaoyuan reviewed Nov 21, 2025

View reviewed changes

src/libraries/Common/src/Interop/Haiku/Interop.Image.cs Outdated Show resolved Hide resolved

src/libraries/Common/src/Interop/Haiku/Interop.Image.cs Outdated Show resolved Hide resolved

trungnt2910 force-pushed the dev/trungnt2910/haiku-lib-diagnostics branch from 822ecd1 to 7863bab Compare November 21, 2025 15:51

build-analysis bot mentioned this pull request Nov 21, 2025

[android] Android.Device_Emulator.JIT.Test failing on emulators with CoreCLR #112633

Open

trungnt2910 mentioned this pull request Nov 22, 2025

Haiku: Initial managed libraries support #121880

Merged

trungnt2910 force-pushed the dev/trungnt2910/haiku-lib-diagnostics branch 2 times, most recently from b7ee79c to f458cbd Compare November 22, 2025 02:53

jeffhandley added the needs-author-action An issue or pull request that requires more info or actions from the author. label Feb 1, 2026

dotnet-policy-service bot added the no-recent-activity label Feb 16, 2026

dotnet-policy-service bot removed needs-author-action An issue or pull request that requires more info or actions from the author. no-recent-activity labels Feb 16, 2026

trungnt2910 and others added 3 commits April 11, 2026 20:06

Haiku: Declare as supported platform

72bd98a

Declare Haiku as a supported platform to MSBuild for all `System.Diagnostics.Process` builds. This prevents `CA1418` when using the `SupportedOSPlatform` attribute with `haiku`.

Haiku: Align attributes with reference API defs

5ed9cf0

trungnt2910 force-pushed the dev/trungnt2910/haiku-lib-diagnostics branch from f458cbd to 5ed9cf0 Compare April 11, 2026 10:08

Copilot AI review requested due to automatic review settings April 11, 2026 10:08

Copilot started reviewing on behalf of trungnt2910 April 11, 2026 10:09 View session

Copilot AI reviewed Apr 11, 2026

View reviewed changes

trungnt2910 added 2 commits April 11, 2026 20:53

Haiku: Fix interop functions

f466d1c

Haiku: Update managed API impl

2563c5e

Copilot started reviewing on behalf of trungnt2910 April 11, 2026 11:54 View session

Copilot AI reviewed Apr 11, 2026

View reviewed changes

Haiku: Remove unused using

7b95fb9

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings April 11, 2026 12:02

trungnt2910 and others added 3 commits April 11, 2026 22:02

Haiku: Remove unused using

8dcb67d

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Haiku: Remove unused using

60c4926

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Haiku: Remove unused using

a1fc850

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot started reviewing on behalf of trungnt2910 April 11, 2026 12:03 View session

Haiku: Apply suggestions from Copilot

89f9e18

Copilot AI reviewed Apr 11, 2026

View reviewed changes

src/native/libs/System.Native/pal_getosinfo.c Show resolved Hide resolved

src/native/libs/System.Native/pal_getosinfo.c Outdated Show resolved Hide resolved

src/libraries/System.Diagnostics.Process/src/System/Diagnostics/ProcessManager.Haiku.cs Show resolved Hide resolved

trungnt2910 added 2 commits April 11, 2026 22:14

Haiku: Apply suggestions from Copilot

7c7efa9

Haiku: Fix char type casts

9c2cc56

Copilot AI review requested due to automatic review settings April 11, 2026 12:24

Copilot started reviewing on behalf of trungnt2910 April 11, 2026 12:25 View session

Copilot AI reviewed Apr 11, 2026

View reviewed changes

Haiku: Add back missing using

6e94817

`System.Collections.Generic` is used by `ArrayBuilder`. I am a victim of Copilot slop.

jkotas requested a review from adamsitnik April 11, 2026 14:29

jkotas reviewed Apr 11, 2026

View reviewed changes

src/libraries/System.Diagnostics.Process/src/System/Diagnostics/ProcessManager.Haiku.cs Outdated Show resolved Hide resolved

Haiku: Improve string extraction from buffer

18685de

Use `ReadOnlySpan` instead of a loop. Co-authored-by: Jan Kotas <jkotas@microsoft.com>

Copilot AI review requested due to automatic review settings April 11, 2026 14:43

Copilot started reviewing on behalf of trungnt2910 April 11, 2026 14:44 View session

Copilot AI reviewed Apr 11, 2026

View reviewed changes

Copilot AI mentioned this pull request Apr 11, 2026

Fix NullReferenceException in DestroyStructure for blittable types #126795

Merged

trungnt2910 mentioned this pull request Apr 12, 2026

Haiku: add platform support #55803

Open

-                string modulePath = GetString(info.name, Interop.Image.MAXPATHLEN);
+                string modulePath;
+                fixed (byte* pName = info.name)
+                {
+                    modulePath = GetString(pName, Interop.Image.MAXPATHLEN);
+                }

Conversation

trungnt2910 commented Nov 21, 2025

Uh oh!

trungnt2910 commented Nov 21, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

trungnt2910 Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

trungnt2910 commented Feb 16, 2026

Uh oh!

jeffhandley commented Feb 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 11, 2026

Choose a reason for hiding this comment

Uh oh!

trungnt2910 Apr 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

trungnt2910 commented Apr 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

trungnt2910 commented Apr 11, 2026 •

edited

Loading