Disable several tests incompatible with interpreter#121401
Merged
janvorli merged 1 commit intodotnet:mainfrom Nov 6, 2025
Merged
Disable several tests incompatible with interpreter#121401janvorli merged 1 commit intodotnet:mainfrom
janvorli merged 1 commit intodotnet:mainfrom
Conversation
These tests use COM interop, native varargs, marshalled pinvoke or handle exception thrown in pinvoked native code.
davidwrighton
approved these changes
Nov 6, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds interpreter incompatibility exclusions for tests that rely on P/Invoke marshalling, varargs, and COM, which are not currently supported by the CoreCLR interpreter (tracked in issue #118965).
Key changes:
- Tests are conditionally skipped or excluded when running under the interpreter
- Two approaches are used: runtime checks with
IsCoreClrInterpreterand build-time exclusions withInterpreterIncompatibleproperty
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/tests/baseservices/callconvs/TestCallingConventions.cs | Adds runtime check to skip NonblittableFunctionPointers() when running under interpreter |
| src/tests/JIT/Directed/pinvoke/calli_excep.il | Adds ActiveIssueAttribute to skip test when running under interpreter |
| src/tests/Interop/IJW/NativeVarargs/NativeVarargsTest.csproj | Sets InterpreterIncompatible property to exclude native varargs test |
| src/tests/Interop/COM/Directory.Build.props | Sets InterpreterIncompatible property to exclude all COM tests |
jkoritzinsky
approved these changes
Nov 6, 2025
This was referenced Nov 6, 2025
Open
Member
Author
|
/ba-g the failures are unrelated infra issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests use COM interop, native varargs, marshalled pinvoke or handle exception thrown in pinvoked native code.