Merged
Conversation
This was causing asan errors. Fixes #121339
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes an unnecessary C-style cast when deleting a USynchCacheStackNode pointer in the Add method of the CSynchCache template class.
Key Changes:
- Simplified the delete operation by removing the
(char *)cast in theAddmethod, making the code cleaner and type-safe.
Comments suppressed due to low confidence (1)
src/coreclr/pal/src/include/pal/synchcache.hpp:181
- The
Flushmethod on line 181 still uses the same C-style cast patterndelete (char *)pTemp;that was just removed from line 156. For consistency and type safety, this should also be changed todelete pTemp;sincepTempis already aUSynchCacheStackNode *pointer allocated withnew USynchCacheStackNode().
delete (char *)pTemp;
Open
3 tasks
jkotas
approved these changes
Nov 5, 2025
Member
|
/ba-g Android timeouts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was causing asan errors.
Fixes #121339