Include the end symbol's size in the range.#121324
Merged
jkoritzinsky merged 1 commit intodotnet:mainfrom Nov 4, 2025
Merged
Conversation
jkotas
approved these changes
Nov 3, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes the calculation of symbol range sizes in the ObjectWriter to include the size of the end symbol. Previously, the range size was calculated as the difference between start and end symbol positions (endSymbol.Value - startSymbol.Value), which only included bytes up to the beginning of the end symbol. The fix adds endSymbol.Size to ensure the entire range, including all bytes of the end symbol, is encompassed.
Key changes:
- Corrects symbol range size calculation to be inclusive of the end symbol's content
This was referenced Nov 4, 2025
Open
Member
Author
|
/ba-g timeouts unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #121310