Remove obsolete NativeExceptionHolder#121315
Merged
jkotas merged 1 commit intodotnet:mainfrom Nov 4, 2025
Merged
Conversation
This holder was used for the old EH on Unix. Now that the old EH was removed from the runtime, it is of no use anymore. This change removes it.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the NativeExceptionHolder exception handling mechanism from the CoreCLR Unix implementation. This mechanism was previously used to track native-to-managed call transitions for exception dispatching.
Key Changes
- Removed the entire
NativeExceptionHolderclass hierarchy and associated infrastructure - Removed the
INSTALL_CALL_TO_MANAGED_EXCEPTION_HOLDERmacro usage from call-to-managed transitions - Cleaned up thread-local storage and stack tracking code for native exception holders
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/coreclr/vm/callhelpers.h | Removed INSTALL_CALL_TO_MANAGED_EXCEPTION_HOLDER macro definition and its invocation in BEGIN_CALL_TO_MANAGEDEX |
| src/coreclr/pal/src/exception/seh.cpp | Removed NativeExceptionHolderBase implementation including thread-local storage and holder lookup functions |
| src/coreclr/pal/inc/pal.h | Removed NativeExceptionHolderBase class declarations, template implementations, and usage in PAL_TRY macro |
| src/coreclr/inc/ex.h | Removed NativeExceptionHolderCatchAll instantiation from EX_TRY_HOLDER macro |
| src/coreclr/dlls/mscordac/mscordac_unixexports.src | Removed export for PAL_GetNativeExceptionHolderHead function |
jkotas
approved these changes
Nov 3, 2025
This was referenced Nov 4, 2025
Open
Member
|
/ba-g infrastructure timeouts on android-arm64 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This holder was used for the old EH on Unix. Now that the old EH has been removed from the runtime quite some time ago, it is of no use anymore.
This change removes it.