Skip to content

Fix build fail in JIT/Directed/jmp/genericjmp test#121290

Merged
jakobbotsch merged 1 commit intodotnet:mainfrom
tomeksowi:missing-Main-genericjmp
Nov 3, 2025
Merged

Fix build fail in JIT/Directed/jmp/genericjmp test#121290
jakobbotsch merged 1 commit intodotnet:mainfrom
tomeksowi:missing-Main-genericjmp

Conversation

@tomeksowi
Copy link
Member

Missing Main method with BuildAllTestsAsStandalone=true.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Nov 3, 2025
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 3, 2025
@clamp03
Copy link
Member

clamp03 commented Nov 3, 2025

For your reference, this is another fix for this issue.
clamp03@3ec247a
Thank you.

@tomeksowi
Copy link
Member Author

tomeksowi commented Nov 3, 2025

For your reference, this is another fix for this issue. clamp03@3ec247a Thank you.

Hm, isn't <OutputType>Library meant for projects included by other tests?

Your commit does fix the build error but genericjmp.sh is not generated so the test is not run, I don't see genericjmp included by anyone.

@clamp03
Copy link
Member

clamp03 commented Nov 3, 2025

You are right. I tested in a wrong way. Thank you.

@jakobbotsch jakobbotsch merged commit 7459320 into dotnet:main Nov 3, 2025
77 checks passed
@janvorli
Copy link
Member

janvorli commented Nov 5, 2025

@tomeksowi, @clamp03 how did the test build fail? I didn't have such a problem when I have created the test last week. And it was not expected for the test to have a .sh file, it is part of the Directed_3 test suite where it gets executed.

@tomeksowi
Copy link
Member Author

tomeksowi commented Nov 5, 2025

@janvorli we were building with env var BuildAllTestsAsStandalone=true where individual .sh files are generated.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

community-contribution Indicates that the PR has been added by a community member needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants