[release/10.0] Don't assume all S_IFREG files are seekable #120839
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-io |
adamsitnik
left a comment
There was a problem hiding this comment.
LGTM, but should we combine it with #120751 (once it gets merged)?
I leave that up to you, my main concern was cleaning up CI on release branches. If you think we should port the product fix as well, feel free to close this PR and then raise a combined PR with the fix once it is ready. Same for release/9.0 branch. |
|
Since this PR is targeting release/10.0, this is a reminder that code complete is Monday November 17. If you want the changes in the PR in the release, please merge it on time. |
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Marking this as approved since it is a test only (assert) change. |
Fixes #121940
Backport of #120736 to release/10.0
/cc @rzikm
Customer Impact
None, the change is in Debug build only and doesn't affect shipped product.
Regression
No, test failures started after adding/updating AzureLinux3 OS in CI matrix.
Testing
CI passes.
Risk
Low, can be considered test-only change as the changes don't propagate to shipped product.