Skip to content

Remove Swagger definition from Echo test servers#120594

Merged
rzikm merged 1 commit intodotnet:mainfrom
rzikm:no-swagger
Oct 10, 2025
Merged

Remove Swagger definition from Echo test servers#120594
rzikm merged 1 commit intodotnet:mainfrom
rzikm:no-swagger

Conversation

@rzikm
Copy link
Member

@rzikm rzikm commented Oct 10, 2025

No description provided.

Copilot AI review requested due to automatic review settings October 10, 2025 10:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the Swagger/OpenAPI definition from the Echo test servers used in the .NET networking tests. The change eliminates the swagger.json file and its associated serving infrastructure, simplifying the test server by removing documentation functionality that is not needed for testing purposes.

  • Removed the swagger.json OpenAPI specification file that documented the Echo test server endpoints
  • Removed the embedded resource configuration and HTTP handler for serving the Swagger documentation
  • Cleaned up the project configuration by removing unnecessary dependencies

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
swagger.json Complete removal of the OpenAPI 3.0.3 specification file documenting the Echo test server endpoints
NetCoreServer.csproj Removed the EmbeddedResource entry for swagger.json from the project file
GenericHandler.cs Removed the HTTP handler logic that served the swagger.json file at the /swagger.json endpoint

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 10, 2025
@rzikm rzikm added area-System.Net and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Oct 10, 2025
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@rzikm rzikm enabled auto-merge (squash) October 10, 2025 10:37
@rzikm rzikm merged commit ce130b8 into dotnet:main Oct 10, 2025
89 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants