Include missing reflected type in hashcode calculation#120449
Merged
jkotas merged 15 commits intodotnet:mainfrom Oct 11, 2025
Merged
Include missing reflected type in hashcode calculation#120449jkotas merged 15 commits intodotnet:mainfrom
jkotas merged 15 commits intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-reflection |
jkotas
reviewed
Oct 6, 2025
src/coreclr/System.Private.CoreLib/src/System/Reflection/RtFieldInfo.cs
Outdated
Show resolved
Hide resolved
Member
|
Can we add some tests to validate that the hashcodes are different for different reflected types? (The test should try multiple types to be resilient against hash collisions.) |
jkotas
reviewed
Oct 7, 2025
src/libraries/System.Runtime/tests/System.Reflection.Tests/EventInfoTests.cs
Outdated
Show resolved
Hide resolved
Member
Looks like NativeAOT needs the same fix. NativeAOT has a separate implementation of reflection that lives under src\coreclr\nativeaot. |
3 tasks
jairbubbles
suggested changes
Oct 8, 2025
jairbubbles
left a comment
There was a problem hiding this comment.
Added a few comment regarding consistency between Equals and GetHashCode on the different classes.
In some cases it might be an issue on the Equals itself and is probably out of the scope of this PR.
src/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeConstructorInfo.CoreCLR.cs
Outdated
Show resolved
Hide resolved
...oreLib/src/System/Reflection/Runtime/EventInfos/NativeFormat/NativeFormatRuntimeEventInfo.cs
Outdated
Show resolved
Hide resolved
...ate.CoreLib/src/System/Reflection/Runtime/MethodInfos/RuntimeConstructedGenericMethodInfo.cs
Outdated
Show resolved
Hide resolved
...stem.Private.CoreLib/src/System/Reflection/Runtime/MethodInfos/RuntimeSyntheticMethodInfo.cs
Outdated
Show resolved
Hide resolved
.../src/System/Reflection/Runtime/PropertyInfos/NativeFormat/NativeFormatRuntimePropertyInfo.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Oct 9, 2025
src/libraries/System.Runtime/tests/System.Reflection.Tests/EventInfoTests.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Oct 9, 2025
jkotas
reviewed
Oct 9, 2025
src/coreclr/System.Private.CoreLib/src/System/Reflection/RtFieldInfo.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Oct 9, 2025
...oreLib/src/System/Reflection/Runtime/EventInfos/NativeFormat/NativeFormatRuntimeEventInfo.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Oct 10, 2025
jkotas
reviewed
Oct 10, 2025
src/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeEventInfo.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Oct 10, 2025
src/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimePropertyInfo.cs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix incorrect runtime member info (
RuntimePropertyInfo,RuntimeMethodInfo,RuntimeEventInfo,RuntimeFieldInfo,RuntimeConstructorInfo) hashcode calculation. Previously it did not include the reflected type, resulting in different sub classes having the same hashcode for properties declared in the base class.Fixes #114280