Skip to content

Remove unsafe bool casts#120400

Merged
EgorBo merged 1 commit intodotnet:mainfrom
xtqqczze:avoid-Unsafe-BitCast2
Oct 14, 2025
Merged

Remove unsafe bool casts#120400
EgorBo merged 1 commit intodotnet:mainfrom
xtqqczze:avoid-Unsafe-BitCast2

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Oct 4, 2025

Follow-up #111024.

Contributes to #94941.

There is likely a minor performance improvement on arm64, but this is not the motivation for the change.

cc: @huoyaoyuan

@huoyaoyuan
Copy link
Member

This line was copied from Half(float) one year ago. Half(float) has been updated.

@xtqqczze
Copy link
Contributor Author

xtqqczze commented Oct 5, 2025

Build Analysis is green.

Copy link
Member

@EgorBo EgorBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@xtqqczze
Copy link
Contributor Author

@EgorBo can we merge?

@EgorBo EgorBo merged commit cda8f8a into dotnet:main Oct 14, 2025
143 of 146 checks passed
@xtqqczze xtqqczze deleted the avoid-Unsafe-BitCast2 branch October 14, 2025 23:44
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Numerics community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants