[browser] build more subsets + runtime interp test#120359
Merged
pavelsavara merged 29 commits intodotnet:mainfrom Oct 8, 2025
Merged
[browser] build more subsets + runtime interp test#120359pavelsavara merged 29 commits intodotnet:mainfrom
pavelsavara merged 29 commits intodotnet:mainfrom
Conversation
Member
Author
|
/azp run runtime |
|
Azure Pipelines failed to run 1 pipeline(s). |
Member
Author
|
/azp run runtime |
|
Azure Pipelines failed to run 1 pipeline(s). |
Member
Author
|
/azp run runtime |
|
Azure Pipelines failed to run 1 pipeline(s). |
Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>
1bfc7c8 to
90eb1c6
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables building more subsets for the browser target and adds runtime interpreter tests for WebAssembly. The main goal is to expand CI capabilities for browser builds by switching from clr.runtime+libs to the full clr+libs subset and building JIT interpreter tests specifically for WASM.
Key changes:
- Switch browser builds to use the full
clr+libssubset in Release configuration - Enable native test building for browser targets by parameterizing library types
- Add conditional compilation for WASM interpreter tests with fallback behavior
Reviewed Changes
Copilot reviewed 122 out of 122 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| eng/pipelines/runtime.yml | Updates browser build to use clr+libs subset and adds interpreter test build step |
| src/tests/CMakeLists.txt | Adds WASM-specific configuration with static library type and compiler flags |
| src/tests/JIT/interpreter/Interpreter.cs | Adds WASM-specific early return and P/Invoke conditionals |
| Multiple CMakeLists.txt files | Replaces hardcoded SHARED with ${TEST_LIB_TYPE} variable |
| Various configuration files | Updates build configurations and dependency handling for browser/WASM targets |
Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>
This was referenced Oct 5, 2025
kg
reviewed
Oct 6, 2025
akoeplinger
approved these changes
Oct 7, 2025
This was referenced Oct 7, 2025
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose: make
clr+libsto build, make runtime tests to build for wasm, but this PR is not trying to run it yet.clr+libson CIReleasebecause that's whatsrc/testsneed, witch coreclr to Debug, because that works.jitinterface_wasm.dlldependencyclr.nativecorelibsubset from browsereng/liveBuilds.targetsmono specific, disable part temporarilyhost.nativesubset temporarilysrc/tests/JIT/interpreter/on CIset(TEST_LIB_TYPE STATIC)for WASM andset(TEST_LIB_TYPE SHARED)for otherssrc/mono/llvm/llvm-init.projfor windows debug