Skip to content

Remove potentially offensive word from code comment#120354

Merged
stephentoub merged 1 commit intodotnet:mainfrom
jeffhandley:jeffhandley/improve-comment
Oct 3, 2025
Merged

Remove potentially offensive word from code comment#120354
stephentoub merged 1 commit intodotnet:mainfrom
jeffhandley:jeffhandley/improve-comment

Conversation

@jeffhandley
Copy link
Member

Detected in a recent scan

@jeffhandley jeffhandley added this to the 11.0.0 milestone Oct 3, 2025
@jeffhandley jeffhandley requested a review from ericstj October 3, 2025 02:53
@jeffhandley jeffhandley self-assigned this Oct 3, 2025
Copilot AI review requested due to automatic review settings October 3, 2025 02:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes a potentially offensive word from a code comment in the SignatureHelper class. The change sanitizes developer-facing documentation while maintaining the same informational content about the implementation approach.

Key Changes

  • Updated comment language to be more professional and inclusive

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 3, 2025
@jeffhandley jeffhandley added area-System.Reflection.Emit and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Oct 3, 2025
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-reflection-emit
See info in area-owners.md if you want to be subscribed.

@jedenastka
Copy link

Lame troll patch. Obviously not offensive.

@stephentoub stephentoub merged commit 1e1451e into dotnet:main Oct 3, 2025
65 checks passed
@stephentoub
Copy link
Member

Lame troll patch. Obviously not offensive.

This is not trolling. This is tweaking the source to avoid warnings from automated tooling. It's simpler and more maintainable to make such a change than to maintain the corresponding suppressions.

@jedenastka
Copy link

This is not trolling. This is tweaking the source to avoid warnings from automated tooling. It's simpler and more maintainable to make such a change than to maintain the corresponding suppressions.

That makes sense I guess.

(I still question why would the tool would include the word "lame" in the blacklist, and I would say this probably should be fixed on the side of that tool, but I'm not a project member and just came across this by chance, so if yall think this is what you need then so be it, not gonna waste time arguing.)

@stephentoub
Copy link
Member

I still question why would the tool would include the word "lame"

Because it's a disability slur.

@jedenastka

This comment was marked as resolved.

@jeffhandley jeffhandley deleted the jeffhandley/improve-comment branch October 3, 2025 16:29
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants