Enable cDAC data descriptor to be built into WASM.#120305
Merged
AaronRobinsonMSFT merged 1 commit intodotnet:mainfrom Oct 1, 2025
Merged
Enable cDAC data descriptor to be built into WASM.#120305AaronRobinsonMSFT merged 1 commit intodotnet:mainfrom
AaronRobinsonMSFT merged 1 commit intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables the Contract-based Debugging and Analysis (cDAC) data descriptor to be built for WebAssembly (WASM) targets. The main purpose is to extend cDAC support to WASM platforms by conditionally excluding precode-related types that are not available on WASM and adding WASM architecture identification.
Key changes:
- Conditionally compile precode-related CDAC types based on FEATURE_PORTABLE_ENTRYPOINTS
- Add WASM architecture string to the global architecture definitions
- Adjust CMake configuration to include cDAC descriptor libraries for WASM builds
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/coreclr/vm/datadescriptor/datadescriptor.inc | Wraps precode-related CDAC type definitions with FEATURE_PORTABLE_ENTRYPOINTS guards and adds WASM architecture string |
| src/coreclr/dlls/mscoree/coreclr/CMakeLists.txt | Moves cDAC descriptor library definitions outside the non-WASM conditional block |
Member
Author
|
/cc @dotnet/dotnet-diag |
Contributor
|
Tagging subscribers to this area: @mangod9 |
pavelsavara
approved these changes
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.