[browser] fix corerun #120289
Merged
[browser] fix corerun #120289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issues with corerun in the browser environment by ensuring proper initialization of the RuntimeAPI object across multiple native modules. The changes address scenarios where the RuntimeAPI might be undefined, which could cause runtime failures.
Key changes:
- Adds defensive initialization of RuntimeAPI objects in native modules
- Updates pipeline configurations to properly handle WASM CoreCLR runtime tests
- Adds eslint disable directive for unused variable warnings
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/native/libs/System.Runtime.InteropServices.JavaScript.Native/interop/index.ts |
Adds defensive initialization for RuntimeAPI object before assignment |
src/native/libs/System.Native.Browser/utils/index.ts |
Adds defensive initialization for RuntimeAPI object before assignment |
src/native/libs/System.Native.Browser/libSystem.Native.Browser.extpost.js |
Adds defensive initialization and eslint disable directive |
src/native/corehost/browserhost/host/index.ts |
Adds defensive initialization for RuntimeAPI object before assignment |
eng/pipelines/runtime.yml |
Updates pipeline condition to include new WASM CoreCLR runtime test path variables |
eng/pipelines/common/templates/wasm-runtime-tests.yml |
Updates path variable reference from generic to mono-specific |
eng/pipelines/common/evaluate-default-paths.yml |
Adds new WASM CoreCLR runtime tests subset and updates path configurations |
src/native/libs/System.Native.Browser/libSystem.Native.Browser.extpost.js
Outdated
Show resolved
Hide resolved
Member
Author
|
I filled #120317 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
internalsandruntimeApiobjectsDOTNET_SYSTEM_GLOBALIZATION_INVARIANT