[clr-interp] Fix Open Virtual Delegates#120280
Merged
davidwrighton merged 3 commits intodotnet:mainfrom Oct 1, 2025
Merged
Conversation
Member
davidwrighton
commented
Sep 30, 2025
- Open virtual delegates have an entrypoint which cannot be processed by NonVirtualEntry2MethodDesc. Handle them specially.
- Open virtual delegates have an entrypoint which cannot be processed by NonVirtualEntry2MethodDesc. Handle them specially.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes handling of open virtual delegates in the CoreCLR interpreter by adding special case detection and processing for open virtual delegate dispatch scenarios.
- Adds detection logic to identify when a delegate uses open virtual dispatch
- Implements proper method resolution for open virtual delegates using
COMDelegate::GetMethodDescForOpenVirtualDelegate - Updates delegate object reference handling to use addresses consistently
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
Removed comment about GC invalidation in GetMethodDescOfVirtualizedCode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.