[clr-interp] Fix behavior of PNSE for intrinsics#120277
Merged
davidwrighton merged 2 commits intodotnet:mainfrom Oct 2, 2025
Merged
[clr-interp] Fix behavior of PNSE for intrinsics#120277davidwrighton merged 2 commits intodotnet:mainfrom
davidwrighton merged 2 commits intodotnet:mainfrom
Conversation
Member
davidwrighton
commented
Sep 30, 2025
- We automatically detected that intrinsics should throw PNSE, but we didn't correctly handle the IL stack in those cases
- We automatically detected that intrinsics should throw PNSE, but we didn't correctly handle the IL stack in those cases
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the behavior of the Platform Not Supported Exception (PNSE) for intrinsics in the CoreCLR interpreter by properly handling the IL stack when these exceptions are thrown.
- Adds proper IL stack manipulation to simulate method execution before throwing PNSE
- Handles both argument removal and return value placement on the stack
- Maintains correct stack state for subsequent interpreter operations
Contributor
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
jakobbotsch
reviewed
Oct 1, 2025
Co-authored-by: Jakob Botsch Nielsen <Jakob.botsch.nielsen@gmail.com>
kg
reviewed
Oct 1, 2025
kg
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.